Gentoo Archives: gentoo-dev

From: Ben de Groot <yngwin@g.o>
To: gentoo-dev@l.g.o
Subject: Re: readme.gentoo.eclass: use echo -e instead of plain echo (Was: Re: [gentoo-dev] readme.gentoo.eclass: Add a DISABLE_AUTOFORMATTING variable=
Date: Mon, 28 Jan 2013 06:37:16
Message-Id: CAB9SyzRi7gL56xsFdaL5AvAy3y9rmtW=-wic0gwjvNiNW+suPQ@mail.gmail.com
In Reply to: Re: readme.gentoo.eclass: use echo -e instead of plain echo (Was: Re: [gentoo-dev] readme.gentoo.eclass: Add a DISABLE_AUTOFORMATTING variable= by Mike Frysinger
1 On 28 January 2013 12:37, Mike Frysinger <vapier@g.o> wrote:
2 > On Sunday 27 January 2013 13:21:27 Pacho Ramos wrote:
3 >> The problem is that it doesn't work so well. If I have the following at
4 >> src_prepare (for example):
5 >> src_prepare() {
6 >> DOC_CONTENTS="You must create a symlink rom /etc/splash/tuxonice
7 >> to the theme you want tuxonice to use, e.g.: \n
8 >> # ln -sfn /etc/splash/emergence /etc/splash/tuxonice \n"
9 >> ...
10 >>
11 >> and I handle ${DOC_CONTENTS} with quotes, it will end writing that tabs
12 >> also in generated file as the contents of the variable will be put
13 >> as-is. On the other hand, if I don't put it between quotes
14 >
15 > forcibly normalizing whitespace for all callers is wrong imo (as is sending it
16 > through `fmt`). if the caller gave you content to write, it should write it.
17 > if the caller didn't want tabs, it shouldn't have used it in the first place.
18 > -mike
19
20 I've started using this eclass, but with README files, not the variable,
21 because this is currently the only way I can make sure it honours my
22 formatting.
23
24 --
25 Cheers,
26
27 Ben | yngwin
28 Gentoo developer
29 Gentoo Qt project lead, Gentoo Wiki admin

Replies