Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 1/2] git-r3.eclass: Update docs to discourage unsafe protocols
Date: Fri, 25 Aug 2017 13:52:23
Message-Id: 1503669126.1016.5.camel@gentoo.org
In Reply to: [gentoo-dev] [PATCH 1/2] git-r3.eclass: Update docs to discourage unsafe protocols by "Michał Górny"
1 W dniu sob, 19.08.2017 o godzinie 10∶25 +0200, użytkownik Michał Górny
2 napisał:
3 > ---
4 > eclass/git-r3.eclass | 14 +++++++++-----
5 > 1 file changed, 9 insertions(+), 5 deletions(-)
6 >
7 > diff --git a/eclass/git-r3.eclass b/eclass/git-r3.eclass
8 > index bc7d4d920299..42b586811368 100644
9 > --- a/eclass/git-r3.eclass
10 > +++ b/eclass/git-r3.eclass
11 > @@ -105,10 +105,14 @@ fi
12 > # @ECLASS-VARIABLE: EGIT_REPO_URI
13 > # @REQUIRED
14 > # @DESCRIPTION:
15 > -# URIs to the repository, e.g. git://foo, https://foo. If multiple URIs
16 > -# are provided, the eclass will consider them as fallback URIs to try
17 > -# if the first URI does not work. For supported URI syntaxes, read up
18 > -# the manpage for git-clone(1).
19 > +# URIs to the repository, e.g. https://foo. If multiple URIs are
20 > +# provided, the eclass will consider the remaining URIs as fallbacks
21 > +# to try if the first URI does not work. For supported URI syntaxes,
22 > +# read up the manpage for git-clone(1).
23 > +#
24 > +# URIs should be using https:// whenever possible. http:// and git://
25 > +# URIs are unsafe and their use (even if only as a fallback) makes
26 > +# MITM attacks possible.
27 > #
28 > # It can be overriden via env using ${PN}_LIVE_REPO variable.
29 > #
30 > @@ -116,7 +120,7 @@ fi
31 > #
32 > # Example:
33 > # @CODE
34 > -# EGIT_REPO_URI="git://a/b.git https://c/d.git"
35 > +# EGIT_REPO_URI="https://a/b.git https://c/d.git"
36 > # @CODE
37 >
38 > # @ECLASS-VARIABLE: EVCS_OFFLINE
39
40 Committed.
41
42 --
43 Best regards,
44 Michał Górny