| 1 |
please check with maintainers, ie in this case me, before jumping in |
| 2 |
and pushing, straight to stable, patches to the known to be fragile core |
| 3 |
part of a whole herd... reviews below |
| 4 |
|
| 5 |
On Sat, 18 Jan 2014 13:12:48 +0000 (UTC) |
| 6 |
"Mark Wright (gienah)" <gienah@g.o> wrote: |
| 7 |
|
| 8 |
> gienah 14/01/18 13:12:48 |
| 9 |
> |
| 10 |
> Added: ocaml-4.01.0-pkg-config-ncurses.patch |
| 11 |
> ocaml-3.11.2-Fix-ocamlopt-w.r.t.-binutils-2.21.patch |
| 12 |
|
| 13 |
in case you hadn't noticed there is a patchset held in gentoo cvs |
| 14 |
repo, please remove those files and make them fit in the workflow |
| 15 |
|
| 16 |
> Log: |
| 17 |
> Fix bug #459512 - dev-lang/ocaml with sys-libs/ncurses[tinfo] |
| 18 |
> - .../work/ocaml-4.00.1/byterun/terminfo.c:54: undefined reference to |
| 19 |
> 'tgetent', thanks to Reinis Danne for reporting (patch by me). Add |
| 20 |
> virtual/pkg-config to DEPEND as the ocaml configure script calls |
| 21 |
> pkg-config. |
| 22 |
|
| 23 |
upstream link ? |
| 24 |
|
| 25 |
patch lgtm but i would have liked to have time to have a word to say... |
| 26 |
I doubt that this tinfo thing has suddenly become ultra urgent |
| 27 |
|
| 28 |
|
| 29 |
> Apply patch from upstream for upstream bug |
| 30 |
> http://caml.inria.fr/mantis/view.php?id=5237 to ocaml-3.11.2. |
| 31 |
|
| 32 |
ocaml 3.11 is still there only because of a slacking arch and has most |
| 33 |
likely other issues, you're wasting your time there :) |
Archives