Gentoo Archives: gentoo-dev

From: hasufell <hasufell@g.o>
To: gentoo-dev@l.g.o, Richard Farina <zerochaos@g.o>
Subject: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: net-analyzer/metasploit/
Date: Fri, 09 Oct 2015 15:43:07
Message-Id: 5617E05F.6050509@gentoo.org
1 On 10/08/2015 11:04 PM, Richard Farina wrote:
2 > commit: 408bb337f1207a7c844d99b70a0f5a164f0b990d
3 > Author: Zero_Chaos <zerochaos <AT> gentoo <DOT> org>
4 > AuthorDate: Thu Oct 8 21:04:12 2015 +0000
5 > Commit: Richard Farina <zerochaos <AT> gentoo <DOT> org>
6 > CommitDate: Thu Oct 8 21:04:48 2015 +0000
7 > URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=408bb337
8 >
9 > net-analyzer/metasploit: I thought keeping the live ebuild in my overlay would decrease the work but it looks like the ruby team and I are duplicating each other and causing more work so moving it back into gentoo
10 >
11
12 Commit message is over-long, please give a short summary and a more
13 detailed description after a newline.
14
15 > net-analyzer/metasploit/metasploit-9999.ebuild | 298 +++++++++++++++++++++++++
16 > 1 file changed, 298 insertions(+)
17 >
18 > diff --git a/net-analyzer/metasploit/metasploit-9999.ebuild b/net-analyzer/metasploit/metasploit-9999.ebuild
19 > new file mode 100644
20 > index 0000000..d07ff32
21 > --- /dev/null
22 > +++ b/net-analyzer/metasploit/metasploit-9999.ebuild
23 > @@ -0,0 +1,298 @@
24 > +# Copyright 1999-2015 Gentoo Foundation
25 > +# Distributed under the terms of the GNU General Public License v2
26 > +# $Header: $
27 > +
28
29 Incorrect header
30
31 [...]
32
33 > +
34 > +QA_PREBUILT="
35 > + usr/$(get_libdir)/${PN}${SLOT}/data/templates/template_x86_linux.bin
36 > + usr/$(get_libdir)/${PN}${SLOT}/data/templates/template_armle_linux.bin
37 > + usr/$(get_libdir)/${PN}${SLOT}/data/templates/template_x86_solaris.bin
38 > + usr/$(get_libdir)/${PN}${SLOT}/data/templates/template_x64_linux.bin
39 > + usr/$(get_libdir)/${PN}${SLOT}/data/templates/template_x64_linux_dll.bin
40 > + usr/$(get_libdir)/${PN}${SLOT}/data/templates/template_x86_bsd.bin
41 > + usr/$(get_libdir)/${PN}${SLOT}/data/templates/template_x64_bsd.bin
42 > + usr/$(get_libdir)/${PN}${SLOT}/data/templates/template_mipsbe_linux.bin
43 > + usr/$(get_libdir)/${PN}${SLOT}/data/templates/template_mipsle_linux.bin
44 > + usr/$(get_libdir)/${PN}${SLOT}/data/meterpreter/msflinker_linux_x86.bin
45 > + usr/$(get_libdir)/${PN}${SLOT}/data/meterpreter/ext_server_sniffer.lso
46 > + usr/$(get_libdir)/${PN}${SLOT}/data/meterpreter/ext_server_networkpug.lso
47 > + usr/$(get_libdir)/${PN}${SLOT}/data/meterpreter/ext_server_stdapi.lso
48 > + usr/$(get_libdir)/${PN}${SLOT}/data/exploits/CVE-2013-2171.bin
49 > + usr/$(get_libdir)/${PN}${SLOT}/data/exploits/CVE-2014-3153.elf
50 > + usr/$(get_libdir)/${PN}${SLOT}/data/android/libs/x86/libndkstager.so
51 > + usr/$(get_libdir)/${PN}${SLOT}/data/android/libs/mips/libndkstager.so
52 > + usr/$(get_libdir)/${PN}${SLOT}/data/android/libs/armeabi/libndkstager.so
53 > + "
54 > +
55
56 I think $(get_libdir) is not allowed in global scope and breaks metadata.
57
58 You can use probably 'usr/lib*/...'
59
60 [...]

Replies