[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: xemacs-elisp-common.eclass xemacs-elisp.eclass

[Donnie Berkholz]

Just a couple comments on this ...

On 07:19 Sat 15 Sep     , Hans de Graaff (graaff) wrote:
> SITEPACKAGE=/usr/lib/xemacs/site-packages

Is using get_libdir() a concern here?

> xemacs-elisp-compile () {
> 	${XEMACS_BATCH_CLEAN} -f batch-byte-compile "$@"
> 	xemacs-elisp-make-autoload-file "$@"
> }

> xemacs-elisp-install () {
> 	local subdir="$1"
> 	shift
> 	(  # use sub-shell to avoid possible environment polution
> 		dodir "${SITEPACKAGE}"/lisp/"${subdir}"
> 		insinto "${SITEPACKAGE}"/lisp/"${subdir}"
> 		doins "$@"
> 	) || die "Installing lisp files failed"
> }

The lack of parallels between these two functions bothers me. One dies 
and the other doesn't, which makes later code using them look wrong. It would be neater to die in both of these functions.

Also, try using { } around a block of code instead of ( ), which creates 
a subshell.

> xemacs-elisp_src_compile() {
> 	xemacs-elisp-compile *.el || die "Compilation of lisp files failed"
> }
>
> xemacs-elisp_src_install () {
> 	xemacs-elisp-install "${PN}" *.el *.elc
> }

Here's the funny-looking bit.

Thanks,
Donnie
-- 
gentoo-dev@g.o mailing list