Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: Mike Pagano <mpagano@g.o>
Subject: Re: [gentoo-dev] [PATCH] Create default implementation of pkg_pretend, move CONFIG_CHECK
Date: Sun, 30 May 2021 17:33:40
Message-Id: 333757ad30185151e9de738839f576638b9cb740.camel@gentoo.org
In Reply to: [gentoo-dev] [PATCH] Create default implementation of pkg_pretend, move CONFIG_CHECK by mpagano@gentoo.org
1 On Sun, 2021-05-30 at 13:29 -0400, mpagano@g.o wrote:
2 > From: Mike Pagano <mpagano@g.o>
3 >
4 > As the purpose of pkg_pretend is to run sanity checks during
5 > dependency calculation time, provide the default implementation
6 > and perform CONFIG_CHECK within it.
7 >
8 > See bug #759238
9 >
10 > Signed-off-by: Mike Pagano <mpagano@g.o>
11 > ---
12 > eclass/linux-mod.eclass | 17 ++++++++++++-----
13 > 1 file changed, 12 insertions(+), 5 deletions(-)
14 >
15 > diff --git a/eclass/linux-mod.eclass b/eclass/linux-mod.eclass
16 > index 11b0fd0cf..42e541ed1 100644
17 > --- a/eclass/linux-mod.eclass
18 > +++ b/eclass/linux-mod.eclass
19 > @@ -135,7 +135,7 @@
20 > # It's a read-only variable. It contains the extension of the kernel modules.
21 >
22 > inherit eutils linux-info multilib toolchain-funcs
23 > -EXPORT_FUNCTIONS pkg_setup pkg_preinst pkg_postinst src_install src_compile pkg_postrm
24 > +EXPORT_FUNCTIONS pkg_setup pkg_preinst pkg_pretend pkg_postinst src_install src_compile pkg_postrm
25 >
26
27 Have you verified that this doesn't override pkg_pretend in any
28 of the eclasses used by the existing consumers?
29
30 --
31 Best regards,
32 Michał Górny