Re: [gentoo-dev] [PATCH 5/5] dev-python/miniupnpc: Use verify-sig.eclass

[Michał Górny]

On Tue, 2020-10-06 at 11:24 +0100, Alexey Sokolov wrote:
> вт, 6 окт. 2020 г. в 10:59, Michał Górny <mgorny@g.o>:
> > Signed-off-by: Michał Górny <mgorny@g.o>
> > ---
> >  dev-python/miniupnpc/Manifest                      |  1 +
> >  dev-python/miniupnpc/miniupnpc-2.1.20191224.ebuild | 11 +++++++----
> >  2 files changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/dev-python/miniupnpc/Manifest b/dev-python/miniupnpc/Manifest
> > index 955881a8af5a..5341c95b6ff0 100644
> > --- a/dev-python/miniupnpc/Manifest
> > +++ b/dev-python/miniupnpc/Manifest
> > @@ -1 +1,2 @@
> >  DIST miniupnpc-2.1.20191224.tar.gz 94740 BLAKE2B 85c0b3eb678685bc7192dbee9440ec5f5be80cbac4d6a4e0a6473662c66f05ef512322cd535a142ffe16d3099a86f78ea70645a7eb2979c373e7a486aeab0cd5 SHA512 d362f914ce9177c1bc46f1f3ae59069c61c0c9c1b6ea7e78003d6b46445d3550835ffc541c2649b5fbc997d035357b461148edb3648135f33d0ce98b54961917
> > +DIST miniupnpc-2.1.20191224.tar.gz.sig 543 BLAKE2B ddbde04faa7bce62fdbb5b555bda9dc9ff69f09cc97442049adc787a03ec91824f14cdddaef6e577cf8d08fa96202fc792333b8dab7e6e8c30847fa9302a35d0 SHA512 b8885d2002259c95ede7ab57aaf82db83c2bd7ace3d0986179efac4245ffd42161049e0167a9ac1ff18de6c8df4d39356f0fb6aa6dada7523a238b4db4838887
> > diff --git a/dev-python/miniupnpc/miniupnpc-2.1.20191224.ebuild b/dev-python/miniupnpc/miniupnpc-2.1.20191224.ebuild
> > index 5e1d489b2e1e..e42aadd90e0d 100644
> > --- a/dev-python/miniupnpc/miniupnpc-2.1.20191224.ebuild
> > +++ b/dev-python/miniupnpc/miniupnpc-2.1.20191224.ebuild
> > @@ -5,11 +5,12 @@ EAPI=7
> >
> >  PYTHON_COMPAT=( python3_{6,7,8} pypy3 )
> >
> > -inherit distutils-r1
> > +inherit distutils-r1 verify-sig
> >
> >  DESCRIPTION="Python bindings for UPnP client library"
> >  HOMEPAGE="http://miniupnp.free.fr/"
> > -SRC_URI="http://miniupnp.free.fr/files/${P}.tar.gz"
> > +SRC_URI="http://miniupnp.free.fr/files/${P}.tar.gz
> > +       verify-sig? ( http://miniupnp.free.fr/files/${P}.tar.gz.sig )"
> >
> >  LICENSE="BSD"
> >  SLOT="0"
> > @@ -17,8 +18,10 @@ KEYWORDS="amd64 ppc ppc64 x86"
> >  IUSE=""
> >
> >  RDEPEND=">=net-libs/miniupnpc-${PV}:0="
> > -DEPEND="${RDEPEND}
> > -       dev-python/setuptools[${PYTHON_USEDEP}]"
> > +DEPEND="${RDEPEND}"
> > +BDEPEND="verify-sig? ( app-crypt/openpgp-keys-miniupnp )"
> > +
> > +VERIFY_SIG_OPENPGP_KEY_PATH=/usr/share/openpgp-keys/miniupnp.asc
>
> Shouldn't this be prefixed with ${BROOT}? (preferably, in the eclass)
>

You are correct indeed.

-- 
Best regards,
Michał Górny