Re: [gentoo-dev] [RFC] Ability to pass arguments to src_configure/src_compile

[Vaeth]

On Sun, 7 Sep 2008, Ciaran McCreesh wrote:
> Vaeth <vaeth@××××××××××××××××××××××××.de> wrote:
> > Santiago M. Mola wrote:
> > > Alec Warner <antarus@g.o> wrote:
> > > > Thomas Anderson <gentoofan23@g.o> wrote:
> > > >>                DEFAULT_SRC_CONFIGURE_USE_{WITHS,ENABLES}
> > > >>                DEFAULT_SRC_CONFIGURE_EXTRA_PARAMS
> >
> > Essentially, this is the suggestion to replace the flexible shell code
> > by some static variables. [...]
> > For all other cases, either *everything* has to be
> > done manually, or you have to introduce even more variables to cover
> > more cases.
>
> The proposal is not designed to replace all cases. It's designed to
> replace the common 50%.

But it doesn't do this well, because it is incompatible with any other
case. Assume, for example, that you have an ebuild in this manner and
that for the new release or for a bugfix you need a small non-included
thing - then this means that you have to rewrite the ebuild almost
completely. The suggestion violates in an extreme way the golden design
rule that small changes in effect should require small changes in source.
Moreover, a second syntax is introduced which everybody has learn,
although it could be done as easily by the standard commands.