Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: Dan Douglas <ormaaj@×××××.com>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] git-r3.eclass: Make EGIT_LIVE_* associative arrays
Date: Thu, 23 Jun 2016 19:44:27
Message-Id: 20160623214411.12d3736f.mgorny@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH] git-r3.eclass: Make EGIT_LIVE_* associative arrays by Dan Douglas
1 On Thu, 23 Jun 2016 14:28:39 -0500
2 Dan Douglas <ormaaj@×××××.com> wrote:
3
4 > On 06/23/2016 01:48 PM, Michał Górny wrote:
5 > > It would be best if we could kill the old way but I doubt it's a good idea right now.
6 >
7 > Yeah I was sad when I realized a nice naming scheme just barely
8 > wasn't going to work thanks to EGIT_LIVE_REPO_URI being shortened to
9 > EGIT_LIVE_REPO, but I didn't want to break it.
10 >
11 > The other thing is the associative arrays not being exportable so if we
12 > want something that can work for interactive use / make.conf / package.env
13 > then we almost need both.
14 >
15 > > One request though: don't use PN but CATEGORY/PN.
16 >
17 > True. I wasn't sure just how far to go with it. If you really wanted
18 > to go all-out I could split arbitrary atoms with versionator and figure out a
19 > custom lookup function to match up keys-values... but ugh. I'll just do
20 > CATEGORY/PN for now. :)
21
22 Well, just to be clear I don't like that magic either. However, I
23 wanted to preserve it for compatibility with old git-2 eclass, i.e. so
24 that when ebuilds are updated from git-2 to git-r3 people's overrides
25 won't suddenly stop working.
26
27 Originally I just wanted to expect people to override EGIT_REPO_URI via
28 package.env but that won't work since ebuilds would override it.
29
30 --
31 Best regards,
32 Michał Górny
33 <http://dev.gentoo.org/~mgorny/>