Re: [gentoo-dev] [PATCH 0/3] toolchain-funcs.eclass: support for querying C++ stdlib and compiler runtime

[Sam James]

> On 8 Oct 2022, at 10:43, Michał Górny <mgorny@g.o> wrote:
>
> Hi,
>
> Here's a patchset adding two new functions along with tests:
>
> - tc-get-cxx-stdlib() that determines C++ stdlib used (libc++ vs
>  libstdc++)
> - tc-get-c-rtlib() that determines C compiler runtime used (libgcc vs
>  compiler-rt)
>
> I've also included a fix for tests failing if ld.gold is not installed.
>

All LGTM, although you forgot to CC toolchain@ ;)

>
> Michał Górny (3):
>  toolchain-funcs.eclass: Add tc-get-cxx-stdlib() to get C++ stdlib
>  toolchain-funcs.eclass: Add tc-get-c-rtlib() to get CC runtime
>  eclass/tests/toolchain-funcs.sh: Handle missing ld.gold gracefully


Best,
sam