Archives
Archives
| From: | Jeroen Roovers <jer@g.o> | ||
|---|---|---|---|
| To: | gentoo-dev@l.g.o | ||
| Subject: | Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in x11-plugins/wmfishtime/files: wmfishtime-1.24-gtk.patch | ||
| Date: | Mon, 23 Jun 2014 02:01:43 | ||
| Message-Id: | 20140623040130.0fe6e30f@marga.jer-c2.orkz.net | ||
| In Reply to: | [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in x11-plugins/wmfishtime/files: wmfishtime-1.24-gtk.patch by Samuli Suominen |
||
| 1 | On Sun, 22 Jun 2014 20:08:41 +0300 |
| 2 | Samuli Suominen <ssuominen@g.o> wrote: |
| 3 | |
| 4 | > LIBS = `$(PKG_CONFIG) gtk+-2.0 --libs` -lm -X11 |
| 5 | |
| 6 | No, it should be |
| 7 | |
| 8 | LIBS = $(shell $(PKG_CONFIG) ...) |
| 9 | |
| 10 | or PKG_CONFIG will be called every time LIBS is evaluated. |
| 11 | |
| 12 | And while you're at it, why not call PKG_CONFIG on x11, too? |
| 13 | |
| 14 | LIBS = $(shell $(PKG_CONFIG) --libs gtk+-2.0 x11) -lm |
| 15 | |
| 16 | |
| 17 | jer |
| Subject | Author |
|---|---|
| Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in x11-plugins/wmfishtime/files: wmfishtime-1.24-gtk.patch | Samuli Suominen <ssuominen@g.o> |