1 |
On Sun, 9 Jun 2013 06:13:32 +0200 |
2 |
yac <yac@g.o> wrote: |
3 |
|
4 |
> I have just noticed that if package is using relative paths in:: |
5 |
> |
6 |
> setup.py data_files = ... |
7 |
> |
8 |
> Then the files are installed right into /usr in case of CPython (The |
9 |
> exact dest is determined by sys.prefix) |
10 |
> |
11 |
> So, I'm thinking it could be worthwhile to add a warning to repoman if |
12 |
> package is using this method as I can imagine this can be easily |
13 |
> overlooked when creating a new package or mostly when bumping one. |
14 |
|
15 |
repoman currently doesn't run any ebuild phases as far as I am aware. |
16 |
For it to be able to warn, it has to run at least the unpack phase; |
17 |
running the unpack phase of each ebuild in the directory is costly. |
18 |
|
19 |
For this to actually properly work, it would need to run all phases; |
20 |
you don't get false positives and it then can actually check the image. |
21 |
|
22 |
What good use has this? Not much. Maintainers should check the image |
23 |
themselves; just to name a few this includes 1) unbundling libraries, 2) |
24 |
checking if everything is present, 3) checking if things are missing |
25 |
(important run time files, doc, examples and sometimes even source), 4) |
26 |
checking that needed libraries (eg. readelf) are listed in DEPEND and |
27 |
in your case 5) checking if things are installed to the correct paths. |
28 |
|
29 |
Just one check won't make up for the others, _you_ have to check them. |
30 |
|
31 |
Although; since this is Python, maybe the Python eclasses can do that? |
32 |
That way you wouldn't have to introduce slower processing in repoman; |
33 |
since eclasses can do these QA checks at the right moment, during merge. |
34 |
|
35 |
-- |
36 |
With kind regards, |
37 |
|
38 |
Tom Wijsman (TomWij) |
39 |
Gentoo Developer |
40 |
|
41 |
E-mail address : TomWij@g.o |
42 |
GPG Public Key : 6D34E57D |
43 |
GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D |