[gentoo-dev] Re: [PATCH] qmake-utils.eclass: add qt{4,5}_get_bindir helper functions

[Davide Pesavento]

On Wed, Feb 18, 2015 at 12:58 PM, Ben de Groot <yngwin@g.o> wrote:
> The attached patch proposes two helper functions to be added to
> qmake-utils.eclass. These functions echo the correct directory where
> qt binaries such as moc and lrelease are located. They can be used in
> ebuilds when such binaries need to be called directly. (Ebuilds should
> not rely on qtchooser for this.)
>
> Please review before I commit.
>

Thanks Ben.

The -x test on line 59 should be a -d.

Also, I'd rephrase the description as follows:
"Echoes the directory where Qt{4,5} binaries are installed."

And you're missing a colon after @FUNCTION.

Thanks,
Davide