Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 4/7] cargo.eclass: set progress.when = "never" in config
Date: Sat, 11 Feb 2023 06:22:21
Message-Id: e1a30cba62e8b6dacf5453c310b8a32f0c48843e.camel@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH 4/7] cargo.eclass: set progress.when = "never" in config by Georgy Yakovlev
1 On Fri, 2023-02-10 at 13:13 -0800, Georgy Yakovlev wrote:
2 > On Fri, 2023-02-10 at 07:03 +0100, Michał Górny wrote:
3 > > On Thu, 2023-02-09 at 12:48 -0800, Georgy Yakovlev wrote:
4 > > > to avoid possible log file pollution
5 > > >
6 > > > Signed-off-by: Georgy Yakovlev <gyakovlev@g.o>
7 > > > ---
8 > > >  eclass/cargo.eclass | 1 +
9 > > >  1 file changed, 1 insertion(+)
10 > > >
11 > > > diff --git a/eclass/cargo.eclass b/eclass/cargo.eclass
12 > > > index 9c624d607cdd..0ab7ee0dc9b2 100644
13 > > > --- a/eclass/cargo.eclass
14 > > > +++ b/eclass/cargo.eclass
15 > > > @@ -273,6 +273,7 @@ cargo_gen_config() {
16 > > >         [term]
17 > > >         verbose = true
18 > > >         $([[ "${NOCOLOR}" = true || "${NOCOLOR}" = yes ]] && echo
19 > > > "color = 'never'")
20 > > > +       progress.when = "never"
21 > > >         $(_cargo_gen_git_config)
22 > > >         _EOF_
23 > > >  
24 > >
25 > > What's that and why don't we want it?  I thought we generally
26 > > preferred
27 > > more verbosity.
28 > >
29 > This knob controls progress bar that can pollute logs in rare cases,
30 > not build verbosity. verbose is set just above.
31 >
32
33 Ah, ok. I thought it was maybe "output something every N minutes when
34 nothing else visible is happening".
35
36 --
37 Best regards,
38 Michał Górny