Gentoo Archives: gentoo-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] ebuild-writing/variables: better describe ROOT
Date: Wed, 11 May 2016 02:51:35
Message-Id: 20160510195029.3e0fb491.dolsen@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH] ebuild-writing/variables: better describe ROOT by Mike Gilbert
1 On Tue, 10 May 2016 22:40:39 -0400
2 Mike Gilbert <floppym@g.o> wrote:
3
4 > On Tue, May 10, 2016 at 9:54 PM, Brian Dolbec <dolsen@g.o>
5 > wrote:
6 > >> I agree, repoman should be catching this stuff.
7 > >>
8 > >
9 > > Then Please contribute some test ebuilds for the gen-b0rk repo to
10 > > test repoman or any other Q/A apps with. If they fail to detect
11 > > the test ebuilds, it will give us something to use to help trace
12 > > the code errors. It'll also make for a much better testing system
13 > > overall for any app performing any type of Q/A on ebuilds.
14 >
15 > I don't think there is a repoman check for ROOT in src functions
16 > (yet). I was just saying that I think it would make sense to add that.
17 >
18
19 As you know, with the modular system now in place, It should be quite
20 easy to add that check now. There is no need to figure out where in
21 over 3000 lines of spaghetti code to insert it without messing up
22 something else.
23
24 Make the test ebuilds, at least one good one, plus however many to test
25 the broken parts. It should only take an hour to add that check.
26
27 --
28 Brian Dolbec <dolsen>