From: | Ulrich Mueller <ulm@g.o> | ||
---|---|---|---|
To: | Conrad Kostecki <conikost@g.o> | ||
Cc: | gentoo-dev@l.g.o | ||
Subject: | Re: [gentoo-dev] [PATCH 2/2] eclass/myspell-r2.eclass: add EAPI 8 support | ||
Date: | Thu, 24 Jun 2021 23:29:42 | ||
Message-Id: | uv962c04w@gentoo.org | ||
In Reply to: | [gentoo-dev] [PATCH 2/2] eclass/myspell-r2.eclass: add EAPI 8 support by Conrad Kostecki |
1 | >>>>> On Thu, 24 Jun 2021, Conrad Kostecki wrote: |
2 | |
3 | > -if [[ ${EAPI:-0} == 7 ]]; then |
4 | > +if [[ ${EAPI:-0} -ge 7 ]]; then |
5 | |
6 | EAPI is a string, not a number. I'd suggest using a string comparison, |
7 | e.g.: |
8 | |
9 | if [[ ${EAPI} != [56] ]]; then |
10 | |
11 | (Negative logic, so there won't be any need to update it again for the |
12 | next EAPI.) |
File name | MIME type |
---|---|
signature.asc | application/pgp-signature |