Archives
Archives
| From: | "Tiziano Müller" <dev-zero@g.o> | ||
|---|---|---|---|
| To: | gentoo-dev@l.g.o | ||
| Subject: | [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-util/qmtest: qmtest-2.3.ebuild ChangeLog qmtest-2.4.ebuild | ||
| Date: | Tue, 22 Jan 2008 12:17:35 | ||
| Message-Id: | fn4ms1$s63$1@ger.gmane.org | ||
| In Reply to: | [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-util/qmtest: qmtest-2.3.ebuild ChangeLog qmtest-2.4.ebuild by Donnie Berkholz |
||
| 1 | Donnie Berkholz wrote: |
| 2 | |
| 3 | > On 19:54 Mon 21 Jan , Joel D. Martin (kanaka) wrote: |
| 4 | >> 1.1 dev-util/qmtest/qmtest-2.4.ebuild |
| 5 | >> |
| 6 | >> file : |
| 7 | >> |
| 8 | http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-util/qmtest/qmtest-2.4.ebuild?rev=1.1&view=markup |
| 9 | >> plain: |
| 10 | >> |
| 11 | http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-util/qmtest/qmtest-2.4.ebuild?rev=1.1&content-type=text/plain |
| 12 | >> |
| 13 | >> Index: qmtest-2.4.ebuild |
| 14 | >> =================================================================== |
| 15 | >> # Copyright 1999-2008 Gentoo Foundation |
| 16 | >> # Distributed under the terms of the GNU General Public License v2 |
| 17 | >> # $Header: /var/cvsroot/gentoo-x86/dev-util/qmtest/qmtest-2.4.ebuild,v |
| 18 | >> # 1.1 2008/01/21 19:54:35 kanaka Exp $ |
| 19 | >> |
| 20 | >> inherit eutils |
| 21 | >> DESCRIPTION="CodeSourcery's test harness system" |
| 22 | >> HOMEPAGE="http://www.codesourcery.com/qmtest/" |
| 23 | >> SRC_URI="http://www.codesourcery.com/public/${PN}/${PF}/${PF}.tar.gz" |
| 24 | >> LICENSE="GPL-2" |
| 25 | >> SLOT="0" |
| 26 | >> |
| 27 | >> KEYWORDS="~amd64 ~x86" |
| 28 | >> IUSE="" |
| 29 | >> |
| 30 | >> DEPEND="dev-lang/python" |
| 31 | >> |
| 32 | >> src_compile() { |
| 33 | >> python setup.py build || die "setup.py build failed" |
| 34 | >> } |
| 35 | >> |
| 36 | >> src_install() { |
| 37 | >> python setup.py install --root ${D} \ |
| 38 | >> || die "setup.py install failed" |
| 39 | >> |
| 40 | >> sed -i "s@${D}@/usr@" ${D}/usr/lib*/python2.4/site-packages/qm/config.py |
| 41 | >> \ || die "Could not adjust install path in config.py" |
| 42 | >> } |
| 43 | > |
| 44 | > This looks like it should use distutils.eclass. |
| 45 | |
| 46 | And it will fail with python-2.5. You should definitely use the |
| 47 | distutils.eclass which also handles the byte-compilation/-cleanup. |
| 48 | |
| 49 | Please also implement a src_test to run the provided tests. If unsure on how |
| 50 | to do that correctly, check other python ebuilds or join #gentoo-python. |
| 51 | |
| 52 | |
| 53 | -- |
| 54 | gentoo-dev@l.g.o mailing list |