Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: [gentoo-dev] [PATCH 2/3] multiprocessing.eclass: Remove bashpid function
Date: Tue, 02 Jan 2018 12:43:36
Message-Id: 20180102124241.21995-2-mgorny@gentoo.org
In Reply to: [gentoo-dev] [PATCH 1/3] multiprocessing.eclass: Remove multijob_* functions by "Michał Górny"
1 Remove the bashpid function that is not used anywhere after the removal
2 of multijob* logic. The unprefixed name can be quite confusing,
3 and the function itself is rather unlikely to be useful.
4 ---
5 eclass/multiprocessing.eclass | 17 -----------------
6 1 file changed, 17 deletions(-)
7
8 diff --git a/eclass/multiprocessing.eclass b/eclass/multiprocessing.eclass
9 index cfe22303043e..6ca9b4fa7850 100644
10 --- a/eclass/multiprocessing.eclass
11 +++ b/eclass/multiprocessing.eclass
12 @@ -26,23 +26,6 @@
13 if [[ -z ${_MULTIPROCESSING_ECLASS} ]]; then
14 _MULTIPROCESSING_ECLASS=1
15
16 -# @FUNCTION: bashpid
17 -# @DESCRIPTION:
18 -# Return the process id of the current sub shell. This is to support bash
19 -# versions older than 4.0 that lack $BASHPID support natively. Simply do:
20 -# echo ${BASHPID:-$(bashpid)}
21 -#
22 -# Note: Using this func in any other way than the one above is not supported.
23 -bashpid() {
24 - # Running bashpid plainly will return incorrect results. This func must
25 - # be run in a subshell of the current subshell to get the right pid.
26 - # i.e. This will show the wrong value:
27 - # bashpid
28 - # But this will show the right value:
29 - # (bashpid)
30 - sh -c 'echo ${PPID}'
31 -}
32 -
33 # @FUNCTION: get_nproc
34 # @USAGE: [${fallback:-1}]
35 # @DESCRIPTION:
36 --
37 2.16.0.rc0