Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: ulm@g.o
Subject: Re: [gentoo-dev] [PATCH eutils 1/2] Add dointo && newinto.
Date: Thu, 16 Aug 2012 20:48:52
Message-Id: 20120816224640.482bd430@pomiocik.lan
In Reply to: Re: [gentoo-dev] [PATCH eutils 1/2] Add dointo && newinto. by Ulrich Mueller
1 On Thu, 16 Aug 2012 22:36:46 +0200
2 Ulrich Mueller <ulm@g.o> wrote:
3
4 > >>>>> On Thu, 16 Aug 2012, Michał Górny wrote:
5 >
6 > > +dointo() {
7 > > + [[ ${#} -gt 2 ]] || die 'Synopsis: dointo <directory>
8 > > <file> [...]' +
9 > > + local directory=${1}
10 > > + shift
11 > > +
12 > > + (
13 > > + insinto "${directory}"
14 >
15 > Shouldn't there be checking for errors here, for the case that insinto
16 > fails?
17
18 Hmm, I don't even know if insinto should ever fail. And if it does,
19 then the following doins should fail as well, I guess.
20
21 But I see no problem adding '&& \' there if necessary.
22
23 > > + doins "${@}"
24
25 --
26 Best regards,
27 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-dev] [PATCH eutils 1/2] Add dointo && newinto. Ulrich Mueller <ulm@g.o>