Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: William Hubbs <williamh@g.o>
Subject: Re: [gentoo-dev] [PATCH 1/1] python.eclass: add PYTHON_COMPAT_ALLOW_EXTRA_IMPLS
Date: Thu, 26 Mar 2020 20:05:12
Message-Id: d0c62957d330713a4eb12d264db9bac041f3469d.camel@gentoo.org
In Reply to: [gentoo-dev] [PATCH 1/1] python.eclass: add PYTHON_COMPAT_ALLOW_EXTRA_IMPLS by William Hubbs
1 On Thu, 2020-03-26 at 14:13 -0500, William Hubbs wrote:
2 > This variable is meant to be set in downstream overlays when they need python
3 > implementations other than the ones we support in the tree.
4 > It should be a space-separated list of extra implementations.
5 >
6 > Signed-off-by: William Hubbs <williamh@g.o>
7 > ---
8 > eclass/python-utils-r1.eclass | 2 ++
9 > 1 file changed, 2 insertions(+)
10 >
11 > diff --git a/eclass/python-utils-r1.eclass b/eclass/python-utils-r1.eclass
12 > index aacee5ac35a..4370c7a825f 100644
13 > --- a/eclass/python-utils-r1.eclass
14 > +++ b/eclass/python-utils-r1.eclass
15 > @@ -43,6 +43,8 @@ _PYTHON_ALL_IMPLS=(
16 > python2_7
17 > python3_6 python3_7 python3_8
18 > )
19 > +[[ -n ${PYTHON_COMPAT_ALLOW_EXTRA_IMPLS[*]} ]] &&
20 > + _PYTHON_ALL_IMPLS+=( ${PYTHON_COMPAT_ALLOW_EXTRA_IMPLS} )
21 > readonly _PYTHON_ALL_IMPLS
22 >
23 > # @ECLASS-VARIABLE: PYTHON_COMPAT_NO_STRICT
24
25 How is this supposed to work, exactly? If you scroll to the next
26 function you'd realize that after this change this 'extra
27 implementation' will most likely be simultaneously considered supported
28 and unsupported.
29
30 --
31 Best regards,
32 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature