| 1 |
> On 18 Dec 2021, at 18:27, Mike Gilbert <floppym@g.o <mailto:floppym@g.o>> wrote: |
| 2 |
> |
| 3 |
> glibc only allows _TIME_BITS=64 when _FILE_OFFSET_BITS=64. |
| 4 |
> |
| 5 |
> Signed-off-by: Mike Gilbert <floppym@g.o <mailto:floppym@g.o>> |
| 6 |
> --- |
| 7 |
> eclass/flag-o-matic.eclass | 3 ++- |
| 8 |
> 1 file changed, 2 insertions(+), 1 deletion(-) |
| 9 |
> |
| 10 |
> diff --git a/eclass/flag-o-matic.eclass b/eclass/flag-o-matic.eclass |
| 11 |
> index d262a60b6bb..32119cb9a52 100644 |
| 12 |
> --- a/eclass/flag-o-matic.eclass |
| 13 |
> +++ b/eclass/flag-o-matic.eclass |
| 14 |
> @@ -193,7 +193,8 @@ filter-lfs-flags() { |
| 15 |
> # _LARGEFILE_SOURCE: enable support for new LFS funcs (ftello/etc...) |
| 16 |
> # _LARGEFILE64_SOURCE: enable support for 64bit variants (off64_t/fseeko64/etc...) |
| 17 |
> # _FILE_OFFSET_BITS: default to 64bit variants (off_t is defined as off64_t) |
| 18 |
> - filter-flags -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE |
| 19 |
> + # _TIME_BITS: default to 64bit time_t (requires _FILE_OFFSET_BITS=64) |
| 20 |
> + filter-flags -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_TIME_BITS=64 |
| 21 |
> } |
| 22 |
> |
| 23 |
> # @FUNCTION: filter-ldflags |
| 24 |
> -- |
| 25 |
> 2.34.1 |
| 26 |
> |
| 27 |
> |
| 28 |
|
| 29 |
|
| 30 |
LGTM and please go ahead so we can move forward with our planning for this (see https://wiki.gentoo.org/wiki/Project:Toolchain/time64_migration <https://wiki.gentoo.org/wiki/Project:Toolchain/time64_migration> for others). |
| 31 |
|
| 32 |
Best, |
| 33 |
sam |
Archives