Gentoo Archives: gentoo-dev

From: "M. J. Everitt" <m.j.everitt@×××.org>
To: gentoo-dev@l.g.o, Mike Gilbert <floppym@g.o>
Cc: udev-bugs@g.o
Subject: Re: [gentoo-dev] [PATCH] udev.eclass: support EAPI 7
Date: Sun, 23 Sep 2018 19:33:44
Message-Id: ee4d0c65-3a51-4d99-2a39-f2347e634630@iee.org
In Reply to: [gentoo-dev] [PATCH] udev.eclass: support EAPI 7 by Mike Gilbert
1 On 23/09/18 16:20, Mike Gilbert wrote:
2 > Signed-off-by: Mike Gilbert <floppym@g.o>
3 > ---
4 > eclass/udev.eclass | 14 +++++++++-----
5 > 1 file changed, 9 insertions(+), 5 deletions(-)
6 >
7 > diff --git a/eclass/udev.eclass b/eclass/udev.eclass
8 > index 4f23c9ebbdf8..baf60584938f 100644
9 > --- a/eclass/udev.eclass
10 > +++ b/eclass/udev.eclass
11 > @@ -1,10 +1,10 @@
12 > -# Copyright 1999-2014 Gentoo Foundation
13 > +# Copyright 1999-2018 Gentoo Authors
14 > # Distributed under the terms of the GNU General Public License v2
15 >
16 > # @ECLASS: udev.eclass
17 > # @MAINTAINER:
18 > # udev-bugs@g.o
19 > -# @SUPPORTED_EAPIS: 0 1 2 3 4 5 6
20 > +# @SUPPORTED_EAPIS: 0 1 2 3 4 5 6 7
21 > # @BLURB: Default eclass for determining udev directories.
22 > # @DESCRIPTION:
23 > # Default eclass for determining udev directories.
24 > @@ -34,12 +34,16 @@ _UDEV_ECLASS=1
25 > inherit toolchain-funcs
26 >
27 > case ${EAPI:-0} in
28 > - 0|1|2|3|4|5|6) ;;
29 > + 0|1|2|3|4|5|6|7) ;;
30 > *) die "${ECLASS}.eclass API in EAPI ${EAPI} not yet established."
31 > esac
32 >
33 > -RDEPEND=""
34 > -DEPEND="virtual/pkgconfig"
35 > +if [[ ${EAPI:-0} == [0123456] ]]; then
36 > + RDEPEND=""
37 > + DEPEND="virtual/pkgconfig"
38 > +else
39 > + BDEPEND="virtual/pkgconfig"
40 > +fi
41 >
42 > # @FUNCTION: _udev_get_udevdir
43 > # @INTERNAL
44 Hate to nit-pick, but this *is* Gentoo .. the last IF, if EAPI <> 7 then
45 BDEPEND could also be dragged in, probably better to explicitly mention '7'.
46 Cheers,
47 Michael.
48 Replying off-list due to black-listing.

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-dev] [PATCH] udev.eclass: support EAPI 7 Mike Gilbert <floppym@g.o>