| 1 |
On 07-08-2012 18:03:14 +0200, Torsten Veller wrote: |
| 2 |
> * "Fabian Groffen (grobian)" <grobian@g.o>: |
| 3 |
> > grobian 12/08/07 15:21:54 |
| 4 |
> > |
| 5 |
> > Modified: ChangeLog |
| 6 |
> > Added: XML-Parser-2.410.0-r1.ebuild |
| 7 |
> > Log: |
| 8 |
> > Fix expat detection for FreeBSD that silently went unnoticed. |
| 9 |
> |
| 10 |
> The following single quotes were dropped: |
| 11 |
> |
| 12 |
> -myconf="EXPATLIBPATH='${EPREFIX}/usr/$(get_libdir)' EXPATINCPATH='${EPREFIX}/usr/include'" |
| 13 |
> +myconf="EXPATLIBPATH=${EPREFIX}/usr/$(get_libdir) EXPATINCPATH=${EPREFIX}/usr/include" |
| 14 |
> |
| 15 |
> Sorry, I don't understand the problem. Is it a general problem with |
| 16 |
> the single quote or a special FreeBSD problem? |
| 17 |
|
| 18 |
I've only observed it happening on FreeBSD indeed. |
| 19 |
|
| 20 |
> I think we should convert all myconf strings to arrays: |
| 21 |
> myconf=( EXPATLIBPATH="${EPREFIX}"/usr/$(get_libdir) EXPATINCPATH="${EPREFIX}"/usr/include ) |
| 22 |
|
| 23 |
I don't understand enough of the Makefile.PL thing to tell why the |
| 24 |
quotes work on Darwin, Solaris, but not FreeBSD 9.1-BETA1. I do know |
| 25 |
that EPREFIX cannot contain spaces though, hence I applied the fix as |
| 26 |
committed. If the array approach works with the eclass, then that'll be |
| 27 |
certainly cleaner. |
| 28 |
|
| 29 |
|
| 30 |
-- |
| 31 |
Fabian Groffen |
| 32 |
Gentoo on a different level |
Archives