Gentoo Archives: gentoo-dev

From: "M. J. Everitt" <m.j.everitt@×××.org>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] glep-0074: Remove single filesystem limitation
Date: Thu, 08 Feb 2018 17:25:59
Message-Id: dcae73a6-0894-898e-f3fc-a16c2c3e0943@iee.org
In Reply to: [gentoo-dev] [PATCH] glep-0074: Remove single filesystem limitation by "Michał Górny"
1 On 08/02/18 17:09, Michał Górny wrote:
2 > Remove the limitation that all files covered by the Manifest must reside
3 > on a single filesystem. This breaks valid uses of overlayfs without
4 > providing any real advantage.
5 >
6 > The removal is justified further in the updated rationale section.
7 > ---
8 > glep-0074.rst | 66 +++++++++++++++++++++++++++++++++++------------------------
9 > 1 file changed, 39 insertions(+), 27 deletions(-)
10 >
11 > RST: https://dev.gentoo.org/~mgorny/tmp/glep-0074.rst
12 > HTML: https://dev.gentoo.org/~mgorny/tmp/glep-0074.html
13 >
14 > diff --git a/glep-0074.rst b/glep-0074.rst
15 > index 3835247..2f8deb2 100644
16 > --- a/glep-0074.rst
17 > +++ b/glep-0074.rst
18 > @@ -6,10 +6,10 @@ Author: Michał Górny <mgorny@g.o>,
19 > Ulrich Müller <ulm@g.o>
20 > Type: Standards Track
21 > Status: Final
22 > -Version: 1
23 > +Version: 1.1
24 > Created: 2017-10-21
25 > -Last-Modified: 2017-12-16
26 > -Post-History: 2017-10-26, 2017-11-16
27 > +Last-Modified: 2018-02-08
28 > +Post-History: 2017-10-26, 2017-11-16, 2018-02-08
29 > Content-Type: text/x-rst
30 > Requires: 59, 61
31 > Replaces: 44, 58, 60
32 > @@ -126,13 +126,6 @@ a different file type. If the tree contain files of other types
33 > that are not otherwise ignored, they need to be covered by an explicit
34 > ``IGNORE``.
35 >
36 > -All the local (non-``DIST``) files covered by a Manifest tree must
37 > -reside on the same filesystem. It is an error to specify entries
38 > -applying to files on another filesystem. If files or directories that
39 > -are not otherwise ignored reside on a different filesystem, or symbolic
40 > -links point to targets on a different filesystem, they must
41 > -be explicitly excluded via ``IGNORE``.
42 > -
43 >
44 > Path and filename encoding
45 > --------------------------
46 > @@ -325,22 +318,18 @@ Algorithm for finding parent Manifests
47 > In order to find the top-level Manifest from the current directory
48 > the following algorithm can be used:
49 >
50 > -1. Store the current directory as *original* and the device ID
51 > - of the containing filesystem (``st_dev``) as *startdev*,
52 > -
53 > -2. If the device ID of the containing filesystem (``st_dev``)
54 > - of the current directory is different than *startdev*, stop.
55 > +1. Store the current directory as *original*,
56 >
57 > -3. If the current directory contains a ``Manifest`` file:
58 > +2. If the current directory contains a ``Manifest`` file:
59 >
60 > a. If an ``IGNORE`` entry in the ``Manifest`` file covers
61 > the *original* directory (or one of the parent directories), stop.
62 >
63 > b. Otherwise, store the current directory as *last_found*.
64 >
65 > -4. If the current directory is the root system directory (``/``), stop.
66 > +3. If the current directory is the root system directory (``/``), stop.
67 >
68 > -5. Otherwise, enter the parent directory and jump to step 2.
69 > +4. Otherwise, enter the parent directory and jump to step 2.
70 >
71 > Once the algorithm stops, *last_found* will contain the relevant
72 > top-level Manifest. If *last_found* is null, then the directory tree
73 >
74 <snip>
75
76 Observation: does RST not support auto-numbering like other formats? It
77 would make renumbering lists like this much easier (and from programming
78 experience, less error-prone). If not, #FEATUREREQ ... :]

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies