| 1 |
On Sun, 2012-08-26 at 22:45 -0400, Alexis Ballier wrote: |
| 2 |
> On Sun, 26 Aug 2012 19:43:32 -0400 |
| 3 |
> Alexandre Rostovtsev <tetromino@g.o> wrote: |
| 4 |
> > The variables that vala_pkg_setup sets are needed only at build time. |
| 5 |
> |
| 6 |
> so it should be vala_src_prepare / unpack instead ? |
| 7 |
> definitely not anything pkg_* imho |
| 8 |
|
| 9 |
IMHO src_prepare or src_unpack would be misleading because the function |
| 10 |
does not modify the package's source and has nothing to do with |
| 11 |
unpacking. It's not an unusual idiom to set various environment |
| 12 |
variables in pkg_setup even if those variables are relevant only at |
| 13 |
build time; gnome-extra/zeitgeist and xfce4-vala/xfce4-vala are typical |
| 14 |
examples that already export VALAC in their pkg_setup(). |
Archives