Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] acct-user.eclass: Support var overrides for user properties
Date: Mon, 04 Jan 2021 18:19:44
Message-Id: d5a3b3389d2690dd87cc2138b60e3dd0699d187e.camel@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH] acct-user.eclass: Support var overrides for user properties by Thomas Deutschmann
1 On Mon, 2021-01-04 at 18:14 +0100, Thomas Deutschmann wrote:
2 > On 2021-01-04 18:08, Michał Górny wrote:
3 > > Introduce a few variables to allow easy overrides of common user account
4 > > proprerties, that is:
5 > >
6 > > - ACCT_USER_<username>_SHELL
7 > > - ACCT_USER_<username>_HOME
8 > > - ACCT_USER_<username>_HOME_OWNER
9 > > - ACCT_USER_<username>_HOME_PERMS
10 > > - ACCT_USER_<username>_GROUPS
11 > > - ACCT_USER_<username>_GROUPS_ADD
12 > >
13 > > The first five variables override the respective ACCT_USER_* variables,
14 > > with ACCT_USER_*_GROUPS being a space-separated list. The *_GROUPS_ADD
15 > > variable appends to groups present in the ebuild, as this seems a common
16 > > necessity.
17 > >
18 > > We do realize that the original requirement of overriding ebuilds
19 > > in a local repository was inconvenient. This new logic should permit
20 > > easy updates via make.conf. Additionally, it has the advantage
21 > > of clearly reporting the changes made in the build logs.
22 > >
23 > > This does not preclude other solutions to the problem. However, this
24 > > is probably the best one and it should become the current
25 > > recommendation.
26 >
27 > This will improve the overlay situation and can be seen as overall
28 > improvement but it doesn't address any shared concerns nor is it a
29 > replacement for the proposed 'acct-user.eclass: don't modify existing
30 > user by default' patch.
31
32 If you read the commit message you'd realize I said that it's not
33 a replacement.
34
35 --
36 Best regards,
37 Michał Górny