Gentoo Archives: gentoo-dev

From: Marek Szuba <marecki@g.o>
To: gentoo-dev@l.g.o
Cc: kde@g.o
Subject: Re: [gentoo-dev] [PATCH] cmake.eclass: support EAPI 8
Date: Mon, 16 Aug 2021 20:48:15
Message-Id: 827f7e88-0c2b-6069-18af-3b0f7a0ddc5a@gentoo.org
In Reply to: [gentoo-dev] [PATCH] cmake.eclass: support EAPI 8 by Marek Szuba
1 A word of explanation seeing as I forgot to use --compose to annotate
2 the patch itself. Looks like Project KDE has got their hands full with,
3 well, KDE, therefore here's my take on bumping EAPI support in
4 cmake.eclass. I am not a maintainer of this eclass so I've only made the
5 smallest possible changes to get it to work with EAPI 8 (i.e. no removal
6 of banned functions etc.) - and fortunately it seems extending the $EAPI
7 check is all that is needed.
8
9 Would be great if someone from kde@g.o. could give their blessing (or
10 lack thereof) to this patch.
11
12
13 On 2021-08-16 17:43, Marek Szuba wrote:
14
15 > Signed-off-by: Marek Szuba <marecki@g.o>
16 > ---
17 > eclass/cmake.eclass | 4 ++--
18 > 1 file changed, 2 insertions(+), 2 deletions(-)
19 >
20 > diff --git a/eclass/cmake.eclass b/eclass/cmake.eclass
21 > index 4bd09459ea6..52bf65a463d 100644
22 > --- a/eclass/cmake.eclass
23 > +++ b/eclass/cmake.eclass
24 > @@ -9,7 +9,7 @@
25 > # Maciej Mrozowski <reavertm@g.o>
26 > # (undisclosed contributors)
27 > # Original author: Zephyrus (zephyrus@××××××.it)
28 > -# @SUPPORTED_EAPIS: 7
29 > +# @SUPPORTED_EAPIS: 7 8
30 > # @BLURB: common ebuild functions for cmake-based packages
31 > # @DESCRIPTION:
32 > # The cmake eclass makes creating ebuilds for cmake-based packages much easier.
33 > @@ -98,7 +98,7 @@ _CMAKE_ECLASS=1
34 > # Helps in improving QA of build systems that write to source tree.
35 >
36 > case ${EAPI} in
37 > - 7) ;;
38 > + 7|8) ;;
39 > *) die "EAPI=${EAPI:-0} is not supported" ;;
40 > esac
41 >
42 >
43
44 --
45 Marecki

Attachments

File name MIME type
OpenPGP_signature.asc application/pgp-signature