Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o, Justin Lecher <jlec@g.o>
Cc: Justin Lecher <jlec@g.o>
Subject: Re: [gentoo-dev] [PATCH 4/8] virtualx.eclass: Ban deprecated functionality in EAPI > 5
Date: Sat, 28 Nov 2015 14:04:12
Message-Id: 2647371C-3C43-4282-850C-EEAA27A61FCD@gentoo.org
In Reply to: [gentoo-dev] [PATCH 4/8] virtualx.eclass: Ban deprecated functionality in EAPI > 5 by Justin Lecher
1 Dnia 28 listopada 2015 14:24:17 CET, Justin Lecher <jlec@g.o> napisał(a):
2 >Signed-off-by: Justin Lecher <jlec@g.o>
3 >---
4 > eclass/virtualx.eclass | 4 ++++
5 > 1 file changed, 4 insertions(+)
6 >
7 >diff --git a/eclass/virtualx.eclass b/eclass/virtualx.eclass
8 >index a7f17ec..615ff0e 100644
9 >--- a/eclass/virtualx.eclass
10 >+++ b/eclass/virtualx.eclass
11 >@@ -59,6 +59,7 @@ case ${VIRTUALX_REQUIRED} in
12 > RDEPEND=""
13 > ;;
14 > optional|tests)
15 >+ [[ ${EAPI} == [2345] ]] || die 'Values "optional" and "tests" are
16 >unsupported for VIRTUALX_REQUIRED'
17
18 You can now make eutils conditional to EAPI.
19
20 > # deprecated section YAY.
21 > eqawarn "VIRTUALX_REQUIRED=optional and VIRTUALX_REQUIRED=tests are
22 >deprecated."
23 > eqawarn "You can drop the variable definition completely from
24 >ebuild,"
25 >@@ -177,6 +178,9 @@ virtualmake() {
26 > Xmake() {
27 > debug-print-function ${FUNCNAME} "$@"
28 >
29 >+ [[ ${EAPI} == [2345] ]] \
30 >+ || die "${FUNCNAME} is removed in EAPI > 5; use Xemake -j1 instead"
31 >+
32 > eqawarn "you should not execute make directly"
33 > eqawarn "rather execute Xemake -j1 if you have issues with parallel
34 >make"
35 > VIRTUALX_COMMAND="emake -j1" virtualmake "$@"
36
37 --
38 Sent from my Android device with K-9 Mail. Please excuse my brevity.

Replies