| 1 |
On 04/18/2012 10:41 AM, Ciaran McCreesh wrote: |
| 2 |
> On Wed, 18 Apr 2012 13:39:59 -0400 |
| 3 |
> Mike Frysinger<vapier@g.o> wrote: |
| 4 |
>> i'm not sure splitting patches out of src_prepare into a dedicated |
| 5 |
>> src_patch step would benefit that much. often times, you need to |
| 6 |
>> mangle the code before/after patching. |
| 7 |
> |
| 8 |
> Right. If we were going to take the EAPI route with this, the easiest |
| 9 |
> way would probably be to require that overridden src_prepare functions |
| 10 |
> call a magic function called "apply_user_patches_here" (and to barf if |
| 11 |
> a src_prepare finished without having called that function). |
| 12 |
|
| 13 |
Also, maybe apply_user_patches_here should have a special return value |
| 14 |
if there are no patches to be applied? That way, src_prepare can avoid |
| 15 |
an eautoreconf call if there are no patches. |
| 16 |
-- |
| 17 |
Thanks, |
| 18 |
Zac |
Archives