1 |
On Sat, Mar 21, 2020 at 6:43 AM Mart Raudsepp <leio@g.o> wrote: |
2 |
> |
3 |
> Ühel kenal päeval, L, 21.03.2020 kell 11:16, kirjutas Pacho Ramos: |
4 |
> > I agree, I see that also Debian is applying it unconditionally even |
5 |
> > when running |
6 |
> > systemd |
7 |
> |
8 |
> But I assume it would be a problem with USE=systemd + USE=-user-session |
9 |
> dbus, so how about instead of this profile business, we then just go |
10 |
> with: |
11 |
> |
12 |
> * Revbump bluez to drop IUSE=user-session, unconditionally apply the |
13 |
> patch and change the dbus dep in systemd conditional to |
14 |
> >=sys-apps/dbus-1.6:=[user-session(+)] |
15 |
> * Fix bluez USE=systemd handling in above revbump as well: --enable- |
16 |
> systemd should always be passed, not controlled by a USE=systemd, |
17 |
> because all it appears to do is decide whether to install systemd |
18 |
> service files, and that should be always done per the small files |
19 |
> policy. |
20 |
> |
21 |
> * Revbump dbus, dropping user-session IUSE and unconditionally passing |
22 |
> --enable-user-session |
23 |
|
24 |
I think we should probably move it behind USE=systemd. It should |
25 |
probably be that way already, but I missed it when adding the |
26 |
user-session flag to the dbus ebuild. |
27 |
|
28 |
There is a quite a bit of conditionally compiled code in dbus-daemon |
29 |
that gets disabled if --disable-systemd is passed to configure. I |
30 |
would guess that dbus.service will not function properly if this code |
31 |
is not enabled. |
32 |
|
33 |
Since we are dropping user-session from IUSE, the following should suffice: |
34 |
|
35 |
$(use_enable systemd user-session) |
36 |
|
37 |
> * After some time (dbus revision with IUSE=user-session has been gone |
38 |
> for a while), remove all of the IUSE=systemd handling from bluez, as |
39 |
> the user-session matching enforcement isn't needed anymore (and the |
40 |
> configure systemd conditional has been nuked per above) |
41 |
> * At that point the package.use entries can be removed altogether as |
42 |
> well, instead of migrating to systemd target profile. |
43 |
|
44 |
Agreed on the rest of the plan. |