Gentoo Archives: gentoo-dev

From: Fabian Groffen <grobian@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Please review: prefix.eclass
Date: Fri, 27 Mar 2009 12:24:29
Message-Id: 20090327122427.GS15265@gentoo.org
In Reply to: Re: [gentoo-dev] Please review: prefix.eclass by Ulrich Mueller
1 On 27-03-2009 13:08:46 +0100, Ulrich Mueller wrote:
2 > >>>>> On Fri, 27 Mar 2009, Fabian Groffen wrote:
3 >
4 > > Please review.
5 >
6 > > r=$?
7 > > eend ${r}
8 > > [[ ${r} != 0 ]] && die "failed to eprefixify ${x}"
9 >
10 > Here you could save a variable, since eend returns the status:
11
12 it wasn't even declared local, so double FAIL.
13
14 > eend $? || die "failed to eprefixify ${x}"
15
16 Applied, thanks!
17
18
19 --
20 Fabian Groffen
21 Gentoo on a different level