1 |
On Fri, 9 Oct 2015 17:32:22 +0200 |
2 |
hasufell <hasufell@g.o> wrote: |
3 |
|
4 |
> On 10/09/2015 01:17 PM, Alexis Ballier wrote: |
5 |
> > commit: 5220bb29741e1685b42a6312c0b7bf2821672040 |
6 |
> > Author: Alexis Ballier <aballier <AT> gentoo <DOT> org> |
7 |
> > AuthorDate: Fri Oct 9 11:16:38 2015 +0000 |
8 |
> > Commit: Alexis Ballier <aballier <AT> gentoo <DOT> org> |
9 |
> > CommitDate: Fri Oct 9 11:16:52 2015 +0000 |
10 |
> > URL: |
11 |
> > https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5220bb29 |
12 |
> > |
13 |
> > eclass: ros-catkin.eclass: Use cmake-utils_src_make instead of |
14 |
> > plain emake for src_test so that it works with ninja too. |
15 |
> > |
16 |
> |
17 |
> |
18 |
> Please try to use short summary lines and put more detailed |
19 |
> description into the commit message after a newline, also see |
20 |
> https://wiki.gentoo.org/wiki/Gentoo_git_workflow#Example |
21 |
> |
22 |
> The prefix is also a bit uncommon, see |
23 |
> https://wiki.gentoo.org/wiki/Gentoo_git_workflow#Commit_message_format |
24 |
|
25 |
yeah, got that wrong; thx; i tried to remember it as '$dir: message', |
26 |
which works in all but this case it seems :) |
27 |
|
28 |
> Ofc, I will expect people to jump in and say "the council hasn't |
29 |
> decided on that yet", but well... it mostly works fine and is not |
30 |
> really controversial. |
31 |
|
32 |
not sure if council approval is needed; uniformity and consistency is |
33 |
way more important than whatever syntax is used |