Re: [gentoo-dev] [PATCH] toolchain-funcs.eclass: Set CHOST within econf_build to fix config.site

[Sam James]

> On 6 Dec 2022, at 09:03, James Le Cuirot <chewi@g.o> wrote:
>
> We were setting CBUILD within econf_build but not CHOST. crossdev's
> /usr/share/config.site relies on both of these to decide whether to load
> configure overrides needed when cross-compiling. Using the wrong
> overrides leads to packages such as Python failing.
>
> Doing this also avoids the need to duplicate the --build and --host
> configure arguments.
>
> Signed-off-by: James Le Cuirot <chewi@g.o>
> ---
> eclass/toolchain-funcs.eclass | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/eclass/toolchain-funcs.eclass b/eclass/toolchain-funcs.eclass
> index a184887ad3b9..61a29d1b6ea6 100644
> --- a/eclass/toolchain-funcs.eclass
> +++ b/eclass/toolchain-funcs.eclass
> @@ -442,7 +442,8 @@ tc-env_build() {
> # @CODE
> econf_build() {
> local CBUILD=${CBUILD:-${CHOST}}
> - tc-env_build econf --build=${CBUILD} --host=${CBUILD} "$@"
> + econf_env() { CHOST=${CBUILD} econf "$@"; }
> + tc-env_build econf_env "$@"
> }
>
> # @FUNCTION: tc-ld-is-gold
> --

Lgtm provided you've tested it in the relevant envs (which I'm sure you have).

Curious how this didn't come up as a problem before, but it
seems fine!

Thanks!

Best,
sam