Re: [gentoo-dev] linux-mod - moving checks to pkg_pretend

[Jaco Kroon]

Hi,

On 2022/06/10 12:07, Ionen Wolkens wrote:

> On Fri, Jun 10, 2022 at 06:03:28AM -0400, Ionen Wolkens wrote:
>> On Fri, Jun 10, 2022 at 11:41:01AM +0200, Jaco Kroon wrote:
>>> Hi All,
>>>
>>> Currently checks for kernel options etc happen in pkg_setup, would it be
>>> possible to move this to pkg_pretend?
>> One problem with pkg_pretend is that it may not even be the right
>> kernel, e.g. it could be using a new gentoo-kernel that was just
>> emerged in the process. There's also USE=symlink which may lead
>> to an entirely non-configured kernel. So pkg_setup check is
>> essential and "moving" wouldn't be right.
>>
>> Copying can "somewhat" work, albeit it could check against different
>> kernels and also cause duplicated messages (former nvidia-drivers
> Actually, also need to consider the case where there's not even
> a kernel yet.
>
> e.g. `emerge gentoo-kernel-bin nvidia-drivers` would fail with
> pkg_pretend and work with pkg_setup
>
> So, if used, pretend would need to be (at least) non-fatal and
> just a warning.

Hmm.  So a newly installed kernel would probably always fail all checks.

Ok, I'm going to leave this as is, but move the DAHDI checks to
pkg_setup regardless just to be more in line with what I now understand
the INTENDED use was.

Kind Regards,
Jaco