Gentoo Archives: gentoo-dev

From: "Justin Lecher (jlec)" <jlec@g.o>
To: "Michał Górny" <mgorny@g.o>, gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 4/8] virtualx.eclass: Ban deprecated functionality in EAPI > 5
Date: Sat, 28 Nov 2015 15:59:37
Message-Id: 5659CF5D.6080602@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH 4/8] virtualx.eclass: Ban deprecated functionality in EAPI > 5 by "Michał Górny"
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA512
3
4 On 28/11/15 16:57, Michał Górny wrote:
5 >
6 >
7 > Dnia 28 listopada 2015 15:08:52 CET, "Justin Lecher (jlec)"
8 > <jlec@g.o> napisał(a): On 28/11/15 15:03, Michał Górny
9 > wrote:
10 >>>>
11 >>>>
12 >>>> Dnia 28 listopada 2015 14:24:17 CET, Justin Lecher
13 >>>> <jlec@g.o> napisał(a):
14 >>>>> Signed-off-by: Justin Lecher <jlec@g.o> ---
15 >>>>> eclass/virtualx.eclass | 4 ++++ 1 file changed, 4
16 >>>>> insertions(+)
17 >>>>>
18 >>>>> diff --git a/eclass/virtualx.eclass
19 >>>>> b/eclass/virtualx.eclass index a7f17ec..615ff0e 100644 ---
20 >>>>> a/eclass/virtualx.eclass +++ b/eclass/virtualx.eclass @@
21 >>>>> -59,6 +59,7 @@ case ${VIRTUALX_REQUIRED} in RDEPEND="" ;;
22 >>>>> optional|tests) + [[ ${EAPI} == [2345] ]] || die 'Values
23 >>>>> "optional" and "tests" are unsupported for
24 >>>>> VIRTUALX_REQUIRED'
25 >>>>
26 >>>> You can now make eutils conditional to EAPI.
27 >
28 > So your idea is only import eutils for EAPIs where I will need
29 > eqawarn
30 >>> from an eclass? As we have no ETA for that to change, I don't
31 >>> see a
32 > good reason to fix that inherit right now.
33 >
34 >> No, only import it for EAPIs in which you actually use it. EAPI 6
35 >> will die instead, unless you missed some more qa warnings.
36
37 Good catch. Thanks
38
39 -----BEGIN PGP SIGNATURE-----
40 Version: GnuPG/MacGPG2 v2.0
41
42 iQJ8BAEBCgBmBQJWWc9dXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
43 ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ0QUU0N0I4NzFERUI0MTJFN0EyODE0NUFF
44 OTQwMkE3OUIwMzUyOUEyAAoJEOlAKnmwNSmi2k4P/ip/shOkEwCXPZlPFeY4qiP1
45 F8fsBAri7M3xlki9DjAp+LoVFVAxVTvoYn8HFWp84gCOjTHSoLbiVpRiX+jKdbUl
46 dcoSrbGtaaKNT038kLrsRsZQTEzARJR3pw2MZdBb4my38c71Vei8uWwZv1CXM1Pi
47 uch5bGjzAbDHHbBa07vkgxNpm03D1fe9d2K8kdxbsFXfTRs25fODP+6R7fzifarc
48 zCYH2Ritif7FXwLwEc1nwveEVt3TnQyxEdPcN5yHYFpQ6GVRQsfJJDk/QauHh9x+
49 kUnmLwhrzc8AhLltboo1lZgXH7/8W1OaXbHPYtAuk3zEETuKBBzNFp8nlDvFLtfp
50 1h9sH9VZCddYy2ckA2BCIRosXyAznzgGS1ub0BQsHyjH+ji++pn4ju4LoJLT7i0v
51 fE07E59ipgA0yq0DbPLp5n/6yhnADj0/C9GaT9FVN+YJYceMejyU3v+Ofn7KRD7n
52 3p8fU4EUFfU0XqufhwTdKuXpcwg2VJm1eSt5DLs4JpA2yNlpgyZev3n+mo1jFrIM
53 RMK9xlcWbsz4oiRUS+uFCVJ4pK6Xa8lqk3BhvbPTCh1tapWivQ00O9iNyj8Wfoeo
54 jV4KQi8ai+1juT+vYvDU3yr831uux4I70D+qfMci+/pQnzHl8AIRicSygUTCD9sl
55 S1MUVE31Ydqg70FjlDAB
56 =NqmF
57 -----END PGP SIGNATURE-----