Gentoo Archives: gentoo-dev

From: Andreas Sturmlechner <asturm@g.o>
To: gentoo-dev@l.g.o
Cc: "Marty E. Plummer" <hanetzer@×××××××××.com>
Subject: Re: [gentoo-dev] [PATCH] eclass/java-utils-2: switch to eapi7-ver
Date: Thu, 21 Feb 2019 14:31:04
Message-Id: 1801787.GisAbXGV1V@tuxbrain
In Reply to: [gentoo-dev] [PATCH] eclass/java-utils-2: switch to eapi7-ver by "Marty E. Plummer"
1 On Montag, 17. Dezember 2018 09:09:13 CET Marty E. Plummer wrote:
2 > @@ -15,7 +15,7 @@
3 > # you should inherit java-pkg-2 for Java packages or java-pkg-opt-2 for
4 > packages # that have optional Java support. In addition you can inherit
5 > java-ant-2 for # Ant-based packages.
6 > -inherit eutils versionator multilib
7 > +inherit eutils multilib
8
9 I would recommend to keep inheriting all those eclasses (including
10 versionator) for EAPI 0-6, in order not to break revdeps with implicit use.
11 Who knows in what shape they are, and no one is going to fix them for a long
12 time. But we don't want to inherit any of them with EAPI-7, hence merge it
13 with below hunk.
14
15 > @@ -25,6 +25,9 @@ export WANT_JAVA_CONFIG="2"
16 > # Prefix variables are only available for EAPI>=3
17 > has "${EAPI:-0}" 0 1 2 && ED="${D}" EPREFIX= EROOT="${ROOT}"
18 >
19 > +# EAPI 7 has version functions built-in. Use eapi7-ver for all earlier
20 > eclasses.
21 > +[[ ${EAPI} == [0123456] ]] && inherit eapi7-ver
22 > +
23 > # @VARIABLE: JAVA_PKG_E_DEPEND
24 > # @INTERNAL
25 > # @DESCRIPTION:
26
27
28 Regards,
29 Andreas

Replies

Subject Author
Re: [gentoo-dev] [PATCH] eclass/java-utils-2: switch to eapi7-ver "Marty E. Plummer" <hanetzer@×××××××××.com>