From: | Donnie Berkholz <dberkholz@g.o> |
---|---|
To: | gentoo-dev@l.g.o, hollow@g.o |
Subject: | [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: depend.apache.eclass |
Date: | Wed, 06 Feb 2008 22:47:45 |
Message-Id: | 20080206224724.GB3772@comet.science.oregonstate.edu |
1 | On 21:20 Wed 06 Feb , Benedikt Boehm (hollow) wrote: |
2 | > Revision Changes Path |
3 | > 1.42 eclass/depend.apache.eclass |
4 | > |
5 | > file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/depend.apache.eclass?rev=1.42&view=markup |
6 | > plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/depend.apache.eclass?rev=1.42&content-type=text/plain |
7 | > diff : http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/depend.apache.eclass?r1=1.41&r2=1.42 |
8 | |
9 | > +check_apache_threads_in() { |
10 | |
11 | "check_" is a really poor function prefix, because it doesn't tell you |
12 | whether it returns success for when threads exist or returns success for |
13 | when it's unthreaded. Rename this something like "has_apache_threads" |
14 | instead. |
15 | |
16 | > + debug-print-function $FUNCNAME $* |
17 | > + |
18 | > + if ! built_with_use www-servers/apache threads ; then |
19 | > + return |
20 | > + fi |
21 | > + |
22 | > + local myforeign="$1" |
23 | > + local myflag="${2:-threads}" |
24 | > + |
25 | > + if ! built_with_use ${myforeign} ${myflag} ; then |
26 | > + echo |
27 | > + eerror "You need to enable USE flag '${myflag}' in ${myforeign} to" |
28 | > + eerror "build a thread-safe version of ${CATEGORY}/${PN} for use" |
29 | > + eerror "with www-servers/apache" |
30 | > + die "Need missing USE flag '${myflag}' in ${myforeign}" |
31 | > + fi |
32 | > +} |
33 | |
34 | Thanks, |
35 | Donnie |
36 | -- |
37 | gentoo-dev@l.g.o mailing list |