| 1 |
On 11:35 Thu 16 Oct , Doug Goldstein wrote: |
| 2 |
> Doug Goldstein wrote: |
| 3 |
> > While the rule of thumb has been if an eclass needs something it should |
| 4 |
> > provide it's own depends. However the virtualx eclass needs to be |
| 5 |
> > different simply because in some cases it's only uses for tests (this is |
| 6 |
> > it's most common usage in the whole) tree. When it's used for tests |
| 7 |
> > pulling in the xorg-server the most ideal situation would be if |
| 8 |
> > xorg-server was only pulled in on USE=test because currently for anyone |
| 9 |
> > emerging an app that uses GTK+ they have a weird situation in the fact |
| 10 |
> > that all of GTK+'s depends that have USE=X use it to mean libX11 (as do |
| 11 |
> > most usages of the X USE flag), however GTK+ itself due to it's usage of |
| 12 |
> > the virtualx eclass pulls in xorg-server when USE=X, which is only used |
| 13 |
> > for tests. This results in a confusing experience for users looking to |
| 14 |
> > built a headless machine. |
| 15 |
> > |
| 16 |
> > It'd be a lot more consistent if ebuilds provided a USE flag or directly |
| 17 |
> > depended on the xorg-server and then used the functions in the eclass. |
| 18 |
> > So in summary, those are the changes I plan on making very shortly. If |
| 19 |
> > someone's got some input, please speak up. |
| 20 |
> > |
| 21 |
> > |
| 22 |
> Alright... after talking to Diego, Dave, and Remi the final result that |
| 23 |
> I've come up with is the following: |
| 24 |
> |
| 25 |
> VIRTUALX_CONDITIONAL_USE="test" |
| 26 |
> |
| 27 |
> inherit virtualx |
| 28 |
> |
| 29 |
> That'll result in virtualx adding the following: |
| 30 |
> |
| 31 |
> DEPEND="test? ( x11-base/xorg-server x11-apps/xhost )" |
| 32 |
> |
| 33 |
> if VIRTUALX_CONDITIONAL_USE is unset (as it will be for all ebuilds |
| 34 |
> initially) the default will be "X". Which means the default is the same |
| 35 |
> as what we've got today. If it's set to an empty string, it'll always be |
| 36 |
> required. Otherwise, it will use the supplied USE flag. |
| 37 |
|
| 38 |
I'm not sure whether this would work, but one idea would be to handle |
| 39 |
dependencies depending on what's in IUSE of the ebuild inheriting. |
| 40 |
|
| 41 |
-- |
| 42 |
Thanks, |
| 43 |
Donnie |
| 44 |
|
| 45 |
Donnie Berkholz |
| 46 |
Developer, Gentoo Linux |
| 47 |
Blog: http://dberkholz.wordpress.com |
Archives