| 1 |
2011-04-03 21:28:02 Tomáš Chvátal napisał(a): |
| 2 |
> Dne 3.4.2011 19:38, Arfrever Frehtes Taifersar Arahesis napsal(a): |
| 3 |
> > I would like to add python-namespaces.eclass. This eclass will be used by a small number of |
| 4 |
> > special packages, which will provide Python namespaces. These packages will be used as |
| 5 |
> > dependencies of other packages already present in the tree. |
| 6 |
> > |
| 7 |
> > Ebuilds using this eclass must set PYTHON_NAMESPACES variable before inheriting this eclass. |
| 8 |
> > Example (from net-zope/namespaces-zope): |
| 9 |
> > PYTHON_NAMESPACES="Products Shared Shared.DC five +zope zope.app" |
| 10 |
> > |
| 11 |
> > This eclass provides 3 public functions: |
| 12 |
> > python-namespaces_src_install() |
| 13 |
> > python-namespaces_pkg_postinst() |
| 14 |
> > python-namespaces_pkg_postrm() |
| 15 |
> > |
| 16 |
> Why you do so much overquoting in the conditions? |
| 17 |
|
| 18 |
I like consistency with python.eclass and improved syntax highlighting :) . |
| 19 |
|
| 20 |
> Why do you die on those arguments, just ignore them... |
| 21 |
|
| 22 |
The policy for Python-related eclasses is to not ignore misusage of functions. |
| 23 |
|
| 24 |
> You could use some eclass-debug calls (see other eclasses) :) |
| 25 |
|
| 26 |
IMHO they are helpless in debugging. 'set -x' enabled by -d option of emerge is more helpful. |
| 27 |
|
| 28 |
> Why do you call those set_metadata right after its creation and delete |
| 29 |
> it right away, does it save so much time it is better than doing it in |
| 30 |
> global scope? |
| 31 |
|
| 32 |
It is used to have appropriate scope for local variables, so that they don't have to be unset |
| 33 |
manually immediately after the code, in which they should exist. |
| 34 |
|
| 35 |
-- |
| 36 |
Arfrever Frehtes Taifersar Arahesis |
Archives