Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sci-geosciences/mapserver: mapserver-5.4.2-r1.ebuild ChangeLog

[Jeremy Olexa]

On 12/23/2010 01:07 PM, Justin (jlec) Lecher wrote:
> On 23/12/10 19:47, Mike Gilbert wrote:
>> On 12/23/2010 12:18 PM, Jeremy Olexa wrote:
>>> FYI: This adds no value to the ebuild. The default src_unpack is ran
>>> when src_unpack() is not defined.
>>
>> Unless src_unpack() is exported in one of the many eclasses that ebuild
>> inherits. In which case this would "un-export" it and bring the behavior
>> back to default.
>>
>
> That's right. The magic comes from the loved python.eclass. If it is not
> added the webapp.eclass does some things.
>

You know...I did test the results before posting to the -dev list ;) So, 
yes, I knew that there was a interesting call in src_unpack from the 
ruby eclass, but it didn't change the results. You could add a comment 
on WHY you explicitly define the function in the future, as I am 
guessing no one besides you currently knows.. :)
-Jeremy

% diff -ur mapserver-5.4.2-r1.orig/ mapserver-5.4.2-r1.edit/
File mapserver-5.4.2-r1.orig/.ipc_in is a fifo while file 
mapserver-5.4.2-r1.edit/.ipc_in is a fifo
File mapserver-5.4.2-r1.orig/.ipc_out is a fifo while file 
mapserver-5.4.2-r1.edit/.ipc_out is a fifo
diff -ur mapserver-5.4.2-r1.orig/temp/environment 
mapserver-5.4.2-r1.edit/temp/environment
--- mapserver-5.4.2-r1.orig/temp/environment    2010-12-23 
21:25:57.216256714 -0600
+++ mapserver-5.4.2-r1.edit/temp/environment    2010-12-23 
21:29:29.858254479 -0600
@@ -297,7 +297,7 @@
  declare -x 
S="/var/tmp/portage/sci-geosciences/mapserver-5.4.2-r1/work/mapserver-5.4.2"
  declare -x SANDBOX_DEBUG="0"
  declare -x SANDBOX_DENY=""
-declare -x SANDBOX_PID="2383"
+declare -x SANDBOX_PID="3207"
  declare -x 
SANDBOX_PREDICT="/var/tmp/portage/sci-geosciences/mapserver-5.4.2-r1/homedir:/dev/crypto:/var/cache/fontconfig"
  declare -x SANDBOX_READ="/:/dev/stdin:/var/tmp"
  declare -x SANDBOX_VERBOSE="1"
@@ -9371,7 +9371,7 @@
  }
  src_unpack ()
  {
-    default
+    ruby_src_unpack "$@"
  }
  strip-flags ()
  {