| 1 |
Hi everyone, |
| 2 |
|
| 3 |
An issue came up with valgrind on the new multilib-portage which adds |
| 4 |
CFLAGS_$target_abi to $CFLAGS [1]. Valgrind fails to compile when -m64 |
| 5 |
is added because it needs to set its own abi flags. I tried to |
| 6 |
filter-flags() it out; however, the -m64 flag also make it into |
| 7 |
CCASFLAGS [2] which filter-flags() does touch. I see no reason not to |
| 8 |
add CCASFLAGS to the list of flags filtered out by filter-flags(), so I |
| 9 |
propose the following patch to flag-o-matic.eclass. Possible badness? |
| 10 |
|
| 11 |
--- flag-o-matic.eclass.orig 2012-02-21 12:38:37.000000000 -0500 |
| 12 |
+++ flag-o-matic.eclass 2012-02-21 12:39:22.000000000 -0500 |
| 13 |
@@ -17,7 +17,7 @@ |
| 14 |
|
| 15 |
# Return all the flag variables that our high level funcs operate on. |
| 16 |
all-flag-vars() { |
| 17 |
- echo {C,CPP,CXX,F,FC,LD}FLAGS |
| 18 |
+ echo {C,CPP,CXX,CCAS,F,FC,LD}FLAGS |
| 19 |
} |
| 20 |
|
| 21 |
# {C,CXX,F,FC}FLAGS that we allow in strip-flags |
| 22 |
@@ -101,7 +101,7 @@ |
| 23 |
# @FUNCTION: filter-flags |
| 24 |
# @USAGE: <flags> |
| 25 |
# @DESCRIPTION: |
| 26 |
-# Remove particular <flags> from {C,CPP,CXX,F,FC,LD}FLAGS. Accepts |
| 27 |
shell globs. |
| 28 |
+# Remove particular <flags> from {C,CPP,CXX,CCAS,F,FC,LD}FLAGS. |
| 29 |
Accepts shell globs. |
| 30 |
filter-flags() { |
| 31 |
_filter-hardened "$@" |
| 32 |
local v |
| 33 |
|
| 34 |
|
| 35 |
|
| 36 |
Ref. |
| 37 |
[1] https://bugs.gentoo.org/show_bug.cgi?id=398825 |
| 38 |
[2] http://www.delorie.com/gnu/docs/automake/automake_50.html |
| 39 |
|
| 40 |
-- |
| 41 |
Anthony G. Basile, Ph.D. |
| 42 |
Gentoo Linux Developer [Hardened] |
| 43 |
E-Mail : blueness@g.o |
| 44 |
GnuPG FP : 8040 5A4D 8709 21B1 1A88 33CE 979C AF40 D045 5535 |
| 45 |
GnuPG ID : D0455535 |
Archives