Archives
Archives
| From: | Ulrich Mueller <ulm@g.o> | ||
|---|---|---|---|
| To: | Thomas Deutschmann <whissi@g.o> | ||
| Cc: | gentoo-dev@l.g.o, Arfrever@××××××.Org, base-system@g.o | ||
| Subject: | Re: [gentoo-dev] [PATCH 1/3] savedconfig.eclass: Make save_config() re-use configuration file scheme used by restore_config() | ||
| Date: | Sat, 03 Aug 2019 16:20:55 | ||
| Message-Id: | w6gef22rzj9.fsf@kph.uni-mainz.de | ||
| In Reply to: | [gentoo-dev] [PATCH 1/3] savedconfig.eclass: Make save_config() re-use configuration file scheme used by restore_config() by Thomas Deutschmann |
||
| 1 | >>>>> On Sat, 03 Aug 2019, Thomas Deutschmann wrote: |
| 2 | |
| 3 | > +# @ECLASS-VARIABLE: _SAVEDCONFIG_CONFIGURATION_FILE |
| 4 | |
| 5 | 31 chars? Seems excessive for a name of a private variable. |
| 6 | |
| 7 | > +# Restores the configuration saved ebuild previously potentially with user edits. |
| 8 | |
| 9 | If have trouble understanding this sentence. |
| 10 | |
| 11 | > + if [[ -r "${configfile}" ]] ; then |
| 12 | |
| 13 | Quotes are not necessary here. |
| File name | MIME type |
|---|---|
| signature.asc | application/pgp-signature |
| Subject | Author |
|---|---|
| Re: [gentoo-dev] [PATCH 1/3] savedconfig.eclass: Make save_config() re-use configuration file scheme used by restore_config() | Thomas Deutschmann <whissi@g.o> |