Re: [gentoo-dev] [PATCH] virtual/opencl: new version

[Michał Górny]

On Sat, 2020-04-04 at 22:59 +0100, Marek Szuba wrote:
> Instead of pulling in various OpenCL runtimes, only depend on
> eselect-opencl and an OpenCL ICD loader (dev-libs/ocl-icd) in order
> to provide hardware-independent header files and libraries for
> OpenCL-aware software to build against. Actual runtimes are now simply
> suggested to the user via a postinst message.
>
> Signed-off-by: Marek Szuba <marecki@g.o>
> ---
>  virtual/opencl/opencl-3.ebuild | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>  create mode 100644 virtual/opencl/opencl-3.ebuild
>
> diff --git a/virtual/opencl/opencl-3.ebuild b/virtual/opencl/opencl-3.ebuild
> new file mode 100644
> index 00000000000..9851d1ccbeb
> --- /dev/null
> +++ b/virtual/opencl/opencl-3.ebuild
> @@ -0,0 +1,31 @@
> +# Copyright 1999-2020 Gentoo Authors
> +# Distributed under the terms of the GNU General Public License v2
> +
> +EAPI=6

Is there really a good reason to use an old EAPI here?

> +
> +inherit multilib-build
> +
> +DESCRIPTION="Virtual for OpenCL API"
> +SLOT="0"
> +KEYWORDS="~amd64 ~x86"
> +
> +RDEPEND="app-eselect/eselect-opencl
> +	dev-libs/ocl-icd[khronos-headers,${MULTILIB_USEDEP}]"

Wouldn't it make sense to remove the virtual and just have stuff depend
on that instead?

> +
> +pkg_postinst() {
> +	elog
> +	elog "In order to take advantage of OpenCL you will need a runtime for your hardware."
> +	elog "Currently included in Gentoo are:"
> +	elog
> +	elog "    dev-libs/intel-neo - integrated Intel GPUs from Broadwell onwards. Open. 64-bit only"
> +	elog "    dev-libs/rocm-opencl-runtime - AMD GPUs supported by the amdgpu kernel driver. Mostly open [1]. 64-bit only"
> +	elog "    media-libs/mesa[opencl] - some older AMD GPUs; see [2]. Open. 32-bit support"
> +	elog "    dev-libs/amdgpu-pro-opencl - AMD Polaris GPUs. Proprietary, provided as-is. 32-bit support"
> +	elog "    dev-util/intel-ocl-sdk - Intel CPUs. Proprietary. 64-bit only"
> +	elog "    x11-drivers/nvidia-drivers[uvm] - Nvidia GPUs; specific package versions required for older ones [3]. Proprietary. 32-bit support"
> +	elog
> +	elog " [1] Proprietary library from dev-libs/hsa-ext-rocr required for image support"
> +	elog " [2] https://dri.freedesktop.org/wiki/GalliumCompute/"
> +	elog " [3] https://www.nvidia.com/en-us/drivers/unix/legacy-gpu/"
> +	elog
> +}

This looks like README.gentoo material.

-- 
Best regards,
Michał Górny