Gentoo Archives: gentoo-dev

From: James Le Cuirot <chewi@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 2/9] multilib-build.eclass: Add missing error checks
Date: Sun, 06 Dec 2015 20:24:29
Message-Id: 20151206202356.5b7a0553@symphony.aura-online.co.uk
In Reply to: [gentoo-dev] [PATCH 2/9] multilib-build.eclass: Add missing error checks by "Michał Górny"
1 On Sun, 6 Dec 2015 19:57:47 +0100
2 Michał Górny <mgorny@g.o> wrote:
3
4 > diff --git a/eclass/multilib-build.eclass
5 > b/eclass/multilib-build.eclass index dd03553..8e58a2b 100644
6 > --- a/eclass/multilib-build.eclass
7 > +++ b/eclass/multilib-build.eclass
8 > @@ -262,19 +262,23 @@ multilib_for_best_abi() {
9 > # runs (if any). Dies if header files differ.
10 > multilib_check_headers() {
11 > _multilib_header_cksum() {
12 > - [[ -d ${ED}usr/include ]] && \
13 > - find "${ED}"usr/include -type f \
14 > - -exec cksum {} + | sort -k2
15 > + set -o pipefail
16 > +
17 > + if [[ -d ${ED}usr/include ]]; then
18 > + find "${ED}"usr/include -type f \
19 > + -exec cksum {} + | sort -k2
20 > + fi
21 > }
22
23 Possibly being dumb here but isn't "set -o pipefail" a global
24 operation? It will continue to take effect even after this function
25 ends?
26
27 --
28 James Le Cuirot (chewi)
29 Gentoo Linux Developer

Replies