[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in rox-base/rox: ChangeLog rox-2.7-r2.ebuild

[Donnie Berkholz]

On 15:05 Mon 17 Dec     , Jim Ramsay (lack) wrote:
> lack        07/12/17 15:05:57
>
>   Modified:             ChangeLog
>   Added:                rox-2.7-r2.ebuild
>   Log:
>   Started using EAPI=1 and IUSE defaults.  Also added new 'video' flag to IUSE (bug 202333)
>   (Portage version: 2.1.3.19)

> 1.1                  rox-base/rox/rox-2.7-r2.ebuild
>
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/rox-base/rox/rox-2.7-r2.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/rox-base/rox/rox-2.7-r2.ebuild?rev=1.1&content-type=text/plain

> IUSE="+svg +video"

svg already defaults on for all the desktop profiles, so I'm not really 
sure what that's gaining you.

> RDEPEND=">=x11-libs/gtk+-2.4
> 	>=dev-libs/glib-2.2
> 	>=dev-libs/libxml2-2.4.23
> 	>=x11-misc/shared-mime-info-0.14
> 	svg? ( gnome-base/librsvg )
> 	!ppc? ( rox-base/mime-editor
> 		rox-base/thumbs
> 		video? ( rox-extra/videothumbnail ) )"

PPC users aren't supposed to get this stuff? If not, is it even a real 
dependency?

> src_compile() {
>
> 	cd ${APPNAME}
>
> 	# Most rox self-compiles have a 'read' call to wait for the user to
> 	# press return if the compile fails.
> 	# Find and remove this:
> 	sed -i.bak -e 's/\<read WAIT\>/#read/' AppRun
>
> 	./AppRun --compile || die "make failed"
> 	(cd src; make clean) > /dev/null
> 	# don't need these directories anymore
> 	if [ -n "${KEEP_SRC}" ]; then
> 		(cd src; make clean) > /dev/null

Subshells are icky.

> 	else
> 		rm -rf src
> 	fi
> 	rm -fr build
>
> 	# Restore the original AppRun
> 	mv AppRun.bak AppRun
> }
>
> # new streamlined install
>
> src_install() {
> 	doman rox.1
>
> 	dodir ${APPDIR}
> 	cp -r ${APPNAME}/ "${D}/${APPDIR}"
>
> 	# add documentation to be proper
> 	( cd ${APPNAME}/Help
> 	dodoc Changes README README-es TODO
> 	)

Icky.

> 	chmod 0755 "${D}/usr/bin/${WRAPPERNAME}"
> 	chmod 0755 "${D}/usr/bin/${WRAPPERNAME}uri"

fperms?

> 	make_desktop_entry ${WRAPPERNAME} ${APPNAME} ${APPNAME}.png "System;Utility;Core;ROX"

Thought I saw something about desktop entries dropping the suffix for 
the icon, but I don't recall the details.

Thanks,
Donnie
-- 
gentoo-dev@g.o mailing list