1 |
On 14:23 Mon 05 Nov , Peter Volkov (pva) wrote: |
2 |
> 1.1 net-firewall/ipset/ipset-2.3.0.20070828.ebuild |
3 |
> |
4 |
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-firewall/ipset/ipset-2.3.0.20070828.ebuild?rev=1.1&view=markup |
5 |
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-firewall/ipset/ipset-2.3.0.20070828.ebuild?rev=1.1&content-type=text/plain |
6 |
|
7 |
> src_defs() { |
8 |
> # these are used in both of src_compile and src_install |
9 |
> myconf="${myconf} PREFIX=" |
10 |
> myconf="${myconf} LIBDIR=/lib" |
11 |
|
12 |
Should this be get_libdir()? |
13 |
|
14 |
Also seems like instead of having a function to do this, you could just |
15 |
define the variables once in pkg_setup() or src_compile() as globals. |
16 |
|
17 |
> pkg_config() { |
18 |
> cd "${ROOT}${PORTAGE_TMPDIR}" |
19 |
> mkdir patch-o-matic-ng |
20 |
> cd patch-o-matic-ng |
21 |
> |
22 |
> IPTVERINS=`echo $(best_version net-firewall/iptables) | \ |
23 |
> sed -n 's:^[^/]*/[[:alpha:]]*-\([0-9]\+\([.][0-9]\+\)*[a-z]\?\(_\(pre\|p\|beta\|alpha\|rc\)[0-9]*\)*\)\(-r[0-9]\+\)\?$:\1:p'` |
24 |
> |
25 |
> einfo "Unpacking patch-o-matic-ng-${POM_PV}" |
26 |
> tar -jxf "${DISTDIR}"/patch-o-matic-ng-${POM_PV}.tar.bz2 || \ |
27 |
> die "Unable to unpack patch-o-matic-ng-${POM_PV}" |
28 |
> einfo "Unpacking iptables-${IPTVERINS}" |
29 |
> tar -jxf "${DISTDIR}"/iptables-${IPTVERINS}.tar.bz2 || \ |
30 |
> die "Unable to unpack iptables-${IPTVERINS}.tar.bz2" |
31 |
|
32 |
Could you just call unpack() here? |
33 |
|
34 |
> einfo "Enter path to your kernel sources, relative to ${ROOT}" |
35 |
> echo -n "[/usr/src/linux]: " |
36 |
> read K_DIR |
37 |
> [ "${ROOT}${K_DIR}" == "/" ] && K_DIR=${ROOT}/usr/src/linux |
38 |
|
39 |
/usr/src/linux should be what's used here, and if they want to change |
40 |
the kernel to affect, they should change where the symlink points |
41 |
instead of having a secondary config mechanism. |
42 |
|
43 |
Thanks, |
44 |
Donnie |
45 |
-- |
46 |
gentoo-dev@g.o mailing list |