Gentoo Archives: gentoo-dev

From: Sam James <sam@g.o>
To: gentoo-dev@l.g.o
Cc: Florian Schmaus <flow@g.o>
Subject: Re: [gentoo-dev] [PATCH] gradle.eclass: add new eclass
Date: Sat, 07 Jan 2023 04:29:37
Message-Id: 44DF820D-602C-4DE6-8BE7-B9E3A858B53D@gentoo.org
In Reply to: [gentoo-dev] [PATCH] gradle.eclass: add new eclass by Florian Schmaus
1 > On 6 Jan 2023, at 17:20, Florian Schmaus <flow@g.o> wrote:
2 >
3 > Signed-off-by: Florian Schmaus <flow@g.o>
4 > ---
5 > eclass/gradle.eclass | 149 +++++++++++++++++++++++++++++++++++++++++
6 > eclass/tests/gradle.sh | 62 +++++++++++++++++
7 > 2 files changed, 211 insertions(+)
8 > create mode 100644 eclass/gradle.eclass
9 > create mode 100755 eclass/tests/gradle.sh
10 >
11 > diff --git a/eclass/gradle.eclass b/eclass/gradle.eclass
12 > [...]
13
14 > +
15 > +# @ECLASS_VARIABLE: EGRADLE_MIN
16 > +# @DEFAULT_UNSET
17 > +# @DESCRIPTION:
18 > +# Minimum required gradle version.
19 > +
20 > +# @ECLASS_VARIABLE: EGRADLE_MAX_EXCLUSIVE
21 > +# @DEFAULT_UNSET
22 > +# @DESCRIPTION:
23 > +# First gradle version that is not supported.
24 > +
25 > +# @ECLASS_VARIABLE: EGRADLE_EXACT_VER
26 > +# @DEFAULT_UNSET
27 > +# @DESCRIPTION:
28 > +# The exact required gradle version.
29 > +
30
31 It feels a pity to not use the now-somewhat standard
32 PYTHON_COMPAT/LUA_COMPAT-style API.
33
34 Is there a reason not to?
35
36 If it doesn't fit how Gradle versioning works / the
37 number of targets is likely to be far too high,
38 It's fine as-is.

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-dev] [PATCH] gradle.eclass: add new eclass Florian Schmaus <flow@g.o>