[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-lang/gnu-smalltalk: ChangeLog gnu-smalltalk-2.3.6.ebuild

[Donnie Berkholz]

On 18:31 Sun 23 Sep     , Luis F. Araujo (araujo) wrote:
> araujo      07/09/23 18:31:15
>
>   Modified:             ChangeLog
>   Added:                gnu-smalltalk-2.3.6.ebuild
>   Log:
>   Adding new version.
>   (Portage version: 2.1.3.9)

> 1.1                  dev-lang/gnu-smalltalk/gnu-smalltalk-2.3.6.ebuild
>
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-lang/gnu-smalltalk/gnu-smalltalk-2.3.6.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-lang/gnu-smalltalk/gnu-smalltalk-2.3.6.ebuild?rev=1.1&content-type=text/plain

> 	epatch ${FILESDIR}/gst-stack-${PV}.patch

Could be spaces in $FILESDIR, needs quotes.

> 	sed -i "s:\$(DESTDIR)\$(bindir)/gst \$\$srcdir/Finish.st \-VisqS \-a \"\$(DESTDIR)\" \$(MODULES): :" ${S}/Makefile.am
> 	sed -i "s:\$(DESTDIR)\$(bindir)/gst \$\$srcdir/Finish.st \-VisqS \-a \"\$(DESTDIR)\" \$(MODULES): :" ${S}/Makefile.in

If you used single quotes around this sed token, you wouldn't need all 
those escapes and it would get a lot more readable.

Also, $S needs to be quoted.

> src_install() {
> 	make prefix=${D}/usr mandir=${D}/usr/share/man infodir=${D}/usr/share/info \
> 		lispdir=${D}/usr/share/emacs/site-lisp/gnu-smalltalk \
> 		libdir=${D}/usr/lib install || die
> 	rm -rf ${D}/usr/include/sigsegv.h \
> 		${D}/usr/include/snprintfv \
> 		${D}/usr/share/aclocal/snprintfv.m4
> 	dodoc AUTHORS COPYING* ChangeLog NEWS README THANKS TODO
> 	rm -rf ${D}/var

$D needs quotes too.

Thanks,
Donnie
-- 
gentoo-dev@g.o mailing list