Archives
Archives
| From: | Anna Vyalkova <cyber+gentoo@×××××.in> | ||
|---|---|---|---|
| To: | gentoo-dev@l.g.o | ||
| Cc: | vim@g.o | ||
| Subject: | Re: [gentoo-dev] [PATCH v5 3/9] vim-plugin.eclass: EAPI 8: install allowed dirs only | ||
| Date: | Mon, 11 Apr 2022 13:08:30 | ||
| Message-Id: | YlQoQ6/Qgu522GQB@sysrq.in | ||
| In Reply to: | Re: [gentoo-dev] [PATCH v5 3/9] vim-plugin.eclass: EAPI 8: install allowed dirs only by Thomas Bracht Laumann Jespersen |
||
| 1 | On 2022-04-11 14:51, Thomas Bracht Laumann Jespersen wrote: |
| 2 | > > + case ${EAPI:-0} in |
| 3 | > > + 6|7) |
| 4 | > > + for d in *; do |
| 5 | > > + [[ -d "${d}" ]] || continue |
| 6 | > > + doins -r "${d}" |
| 7 | > > + done ;; |
| 8 | > > + *) |
| 9 | > > + for d in "${_VIM_PLUGIN_ALLOWED_DIRS[@]}" "${@}"; do |
| 10 | > > + [[ -d "${d}" ]] || continue |
| 11 | > > + doins -r "${d}" |
| 12 | > > + done ;; |
| 13 | > > + esac |
| 14 | > |
| 15 | > Could you use "8)" instead of "*)" here? There should only be 6, 7, and 8 to |
| 16 | > handle here. |
| 17 | |
| 18 | Other versions don't pass the EAPI guard. Also this solution is |
| 19 | more future-proof. |