| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA256 |
| 3 |
|
| 4 |
On 03/08/15 03:34 AM, Daniel Campbell (zlg) wrote: |
| 5 |
> On 08/02/2015 10:33 AM, Andrew Savchenko wrote: |
| 6 |
>> On Mon, 3 Aug 2015 00:34:51 +0800 Ben de Groot wrote: |
| 7 |
>>> Recently some team members of the Qt project have adopted |
| 8 |
>>> these ebuild policies: |
| 9 |
>>> https://wiki.gentoo.org/wiki/Project:Qt/Policies |
| 10 |
>>> |
| 11 |
>>> I have an issue with the policy adopted under "Requires one of |
| 12 |
>>> two Qt versions". In my opinion, in the case where a package |
| 13 |
>>> offers a choice between qt4 or qt5, we should express this in |
| 14 |
>>> explicit useflags |
| 15 |
> |
| 16 |
>> This is what the policy does: "Implement both qt4 and qt5 USE |
| 17 |
>> flags" |
| 18 |
> |
| 19 |
>>> and a REQUIRED_USE="^^ ( qt4 qt5 )". This offers the user the |
| 20 |
>>> clearest choice. |
| 21 |
> |
| 22 |
>> This will create insane amount of blockers if users have both |
| 23 |
>> flags in make.conf (and this is a common scenario). |
| 24 |
> |
| 25 |
|
| 26 |
Why exactly do we need to force-off the use flag for the one that |
| 27 |
won't be used, anyways? Yes, there are qt4 deps in VDB that likely |
| 28 |
won't be necessary, which causes --depclean to not necessarily be able |
| 29 |
to make -as clean- a system, but realistically this is pretty minor. |
| 30 |
Also, i don't see why end-users are going to care; if they specify |
| 31 |
USE="qt4 qt5" then they should expect the package to depend on both |
| 32 |
sets of the qt deps. |
| 33 |
|
| 34 |
As for the ambiguity of which one the package will use, I think we can |
| 35 |
satisfy that the same way we do slots -- that is, the one with the |
| 36 |
larger ${PV} (ie qt5) is the one that will be used when both are |
| 37 |
available. Intuitive, simple, and the system "just works". |
| 38 |
|
| 39 |
Are there any cases where things actually break if a package has both |
| 40 |
flags enabled? IE, is three a package with IUSE="qt4 qt5" that when |
| 41 |
both flags are enabled would build for qt5 only, and happens to be a |
| 42 |
dependency atom of something else that needs it to have qt4 support? |
| 43 |
That to me is the only case where a REQUIRED_USE needs to be set on a |
| 44 |
package. |
| 45 |
|
| 46 |
|
| 47 |
|
| 48 |
|
| 49 |
-----BEGIN PGP SIGNATURE----- |
| 50 |
Version: GnuPG v2 |
| 51 |
|
| 52 |
iF4EAREIAAYFAlXA0roACgkQAJxUfCtlWe0CMgD/QDNIoY5Ug2f3+6OwvpIX+KG3 |
| 53 |
EiF8jm7yhzgoWck4wE8A+wYqFvyKoAedjdNMR6JKfSTuKQLKj0/PoqPu3tqXfkcG |
| 54 |
=l8Bx |
| 55 |
-----END PGP SIGNATURE----- |
Archives